DAH-2643 handle diff response

[tallulahkay]

Description

When the change to a salesforce field is large, the event from Salesforce sends a diff instead of the whole content. This PR gets the content from the listing when a diff is received and uses the content from the listing to get the translation.

Jira ticket

DAH-2643

Checklist before requesting review

Version Control

• branch name begins with angular if it contains updates to Angular code
• branch name contains the Jira ticket number
• PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

• the set of changes is small
• if the set of changes cannot be small, reviewers have been forewarned
• code meets test coverage thresholds
• code is properly formatted
• code is linted
• code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
• automated tests pass
• if the code changes the UI, it matches the UI design exactly

Review instructions

• instructions specify which environment(s) it applies to
• instructions have already been performed at least once
• instructions can be followed by PA testers
• instructions specify if it can only be followed by an engineer

Request review

• PR has needs review label
• Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
• If time sensitive, notify engineers in Slack

[jimlin-sfgov]

question: This will update the cache for the listing, will there be any weird interactions with the behavior getting implemented in this PR: #2283 ?

Also, I'm a bit apprehensive about mixing concerns, i.e. updating the Listing cache from within this service.

[tallulahkay]

Yeah good point - we can just not do a get without worrying about the cache in this case

[cade-exygy]

Can we place the code for handling the diff in another function?

We shouldn't have to get the listing everytime in this function, only if we encounter a diff object

[tallulahkay]

It's tough because we only know if it's a diff when we look at the individual values. Having to check if there are diffs ahead of processing means we have to loop through all the values an extra time. I pushed an update so the listing gets called on the first diff only. Let me know what you think!

[cade-exygy]

Is it possible for us to have a test that explicitly handles the diff case?

[jimlin-sfgov]

LG

works for rich text too!

:ZH=>"<p><span style=\"color: rgb(68, 68, 68);\">除了符合收入和家庭规模规则的资格外，申请人还必须符合建筑物的规则</span></p><p><br></p><p><strong style=\"color: rgb(0, 0, 0); font-size: 16px; background-color: rgb(255, 255, 255); font-family: courier;\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得 到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</strong></p><p><br></p><p style=\"text-align: right;\"> <em style=\"color: rgb(0, 0, 0); font-size: 9px; background-color: rgb(255, 255, 255); font-family: serif;\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</em></p><p style=\"text-align: right;\"><br></p><p style=\"text-align: center;\"> <strike style=\"color: rgb(0, 0, 0); font-size: 36px; background-color: rgb(255, 255, 255); font-family: verdana;\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦 和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</strike></p><p style=\"text-align: center;\"><br></p><ol><li><span style=\"color: rgb(0, 0, 0); font-size: 14px; background-color: rgb(255, 255, 255);\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</span></li><li><span style=\"color: rgb(0, 0, 0); font-size: 14px; background-color: rgb(255, 255, 255);\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</span></li><li><span style=\"color: rgb(0, 0, 0); font-size: 14px; background-color: rgb(255, 255, 255);\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</span></li><li><span style=\"color: rgb(0, 0, 0); font-size: 14px; background-color: rgb(255, 255, 255);\">照顾病人、遵守医生的要求很重要，但这是一个充满痛苦和磨难的时期。细究起来，任何人都不应该从事任何一种工作，除非他能从中得到一些好处。不要在痛中怒，在训斥中在快感中，他要从痛中做一根毛，希望没有滋生。除非被情欲蒙蔽了双眼，否则就不会出来；放弃职责而软化内心的人就是过错，那就是辛劳。</span></li></ol>"

[jimlin-sfgov]

suggestion (non-blocking): Do a little extra computation to avoid nesting conditionals

if values.values.all? { |value| value.is_a?(String) }
  listing = nil
else
  listing = Request.new(parse_response: true).get(
    "/ListingDetails/#{CGI.escape(listing_id)}",
  ).first
end

values.each do |key, value|
  # ...
end

[tallulahkay]

The extra computation is exactly what I was trying to avoid - do you think the extra computation is ok in this case?

[jimlin-sfgov]

I think it's okay, this computation doesn't seem too resource-heavy.

[tallulahkay]

I'm going to leave it as is - it seems the linter thinks that bumps the cyclomatic complexity up too high (probably bc it adds a second loop)