Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-2647 Human Translations 2024-09-05 #2293

Merged
merged 10 commits into from
Sep 16, 2024

Conversation

jimlin-sfgov
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov commented Sep 10, 2024

Description

Update translations from the most recent Lion Bridge translation order. Also, clean up translation files.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-2647

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions have already been performed at least once
  • instructions can be followed by PA testers
  • instructions specify if it can only be followed by an engineer

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2293 September 10, 2024 23:56 Inactive
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2293 September 11, 2024 00:11 Inactive
@jimlin-sfgov jimlin-sfgov force-pushed the DAH-2647-human-translations-2024-09-05 branch from 9b1bed0 to 6c0c67c Compare September 13, 2024 01:07
@jimlin-sfgov jimlin-sfgov requested review from a team, chadbrokaw and tallulahkay and removed request for a team September 14, 2024 00:08
@jimlin-sfgov jimlin-sfgov added the needs review Pull request needs review label Sep 14, 2024
@jimlin-sfgov jimlin-sfgov force-pushed the DAH-2647-human-translations-2024-09-05 branch from 6c0c67c to 9c83202 Compare September 16, 2024 16:47
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2293 September 16, 2024 16:47 Inactive
@jimlin-sfgov jimlin-sfgov marked this pull request as ready for review September 16, 2024 16:49
Copy link
Contributor

@tallulahkay tallulahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something going on with this translation:
Screenshot 2024-09-16 at 10 12 27 AM

@jimlin-sfgov
Copy link
Collaborator Author

@tallulahkay Good catch, the Spanish translation order is actually littered with this problem, I'll be going into Phrase to fix it.

@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2293 September 16, 2024 19:02 Inactive
Copy link
Contributor

@tallulahkay tallulahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimlin-sfgov jimlin-sfgov merged commit d2fe4b7 into main Sep 16, 2024
18 checks passed
@jimlin-sfgov jimlin-sfgov deleted the DAH-2647-human-translations-2024-09-05 branch September 16, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants