Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-2720 change new password default visibility #2302

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Sep 17, 2024

Description

This ticket changes the default visibility for the new password field so that it is visible by default.

Jira ticket

DAH-2720

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2302 September 17, 2024 15:39 Inactive
@chadbrokaw chadbrokaw marked this pull request as ready for review September 17, 2024 16:03
@chadbrokaw chadbrokaw requested review from a team, cliu02 and cade-exygy and removed request for a team September 17, 2024 19:24
Copy link
Collaborator

@cliu02 cliu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chadbrokaw chadbrokaw force-pushed the DAH-2720_default_password_visibility branch from 45b5f4e to 1f8dbbd Compare September 18, 2024 22:49
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2302 September 18, 2024 22:50 Inactive
@chadbrokaw chadbrokaw merged commit 583e25c into main Sep 19, 2024
18 checks passed
@chadbrokaw chadbrokaw deleted the DAH-2720_default_password_visibility branch September 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants