DAH-2876 feat: allow redirect after sign in

app/assets/json/translations/react/en.json

@@ -1579,6 +1579,7 @@
   "signIn.fillInFaster": "Fill in applications faster",
   "signIn.forgotPassword": "Forgot password?",
   "signIn.loggedOutDueToInactivity": "We care about your security. We logged you out due to inactivity. Please sign in to continue.",
+  "signIn.loginRequired": "You must be signed in to see this page. Sign in to continue.",
   "signIn.newAccount.p1": "We sent a link to %{email}.",
   "signIn.newAccount.p2": "Follow the link in your email to finish creating your account. It expires after 24 hours.",
   "signIn.newAccount.sendEmailAgainButton": "Send email again",

app/javascript/__tests__/pages/SignIn.test.tsx

@@ -284,6 +284,16 @@ describe("<SignIn />", () => {
     })
   })
 
+  it("shows the sign in required banner", async () => {
+    window.sessionStorage.setItem("alert_message_secondary", t("signIn.loginRequired"))
+
+    render(<SiteAlert type="secondary" />)
+    window.sessionStorage.setItem("redirect", "account")
+
+    await renderAndLoadAsync(<SignIn assetPaths={{}} />)
+    expect(screen.getByText(t("signIn.loginRequired"))).not.toBeNull()
+  })
+
   it("shows the timeout limit banner", async () => {
     const mockGetItem = jest.fn()
     const mockSetItem = jest.fn()

app/javascript/authentication/SignInForm.tsx

@@ -13,7 +13,7 @@ import {
 import { Link, Heading } from "@bloom-housing/ui-seeds"
 import { FieldValues, SubmitHandler, useForm } from "react-hook-form"
 
-import { getForgotPasswordPath, getMyAccountPath } from "../util/routeUtil"
+import { getSignInRedirectUrl, getForgotPasswordPath } from "../util/routeUtil"
 import EmailFieldset from "../pages/account/components/EmailFieldset"
 import PasswordFieldset from "../pages/account/components/PasswordFieldset"
 import "../pages/account/styles/account.scss"
@@ -130,7 +130,7 @@ const SignInForm = () => {
 
     signIn(email, password)
       .then(() => {
-        window.location.href = getMyAccountPath()
+        window.location.href = getSignInRedirectUrl()
         window.scrollTo(0, 0)
       })
       .catch((error: AxiosError<{ error: string; email: string }>) => {

app/javascript/pages/account/account-settings.tsx

@@ -41,6 +41,7 @@ import { FormHeader, FormSection, getDobStringFromDobObject } from "../../util/a
 import { AxiosError } from "axios"
 import { ErrorSummaryBanner } from "./components/ErrorSummaryBanner"
 import { ExpandedAccountAxiosError, getErrorMessage } from "./components/util"
+import { setSiteAlertMessage } from "../../components/SiteAlert"
 
 const Banner = ({
   showBanner,
@@ -456,7 +457,8 @@ const AccountSettingsPage = () => {
   const { profile, loading, initialStateLoaded } = React.useContext(UserContext)
 
   if (!profile && !loading && initialStateLoaded) {
-    // TODO: Redirect to React sign in page and show a message that user needs to sign in
+    window.sessionStorage.setItem("redirect", "settings")
+    setSiteAlertMessage(t("signIn.loginRequired"), "secondary")
     window.location.href = getSignInPath()
     return null
   }

app/javascript/pages/account/my-account.tsx

@@ -10,6 +10,7 @@ import {
   getSignInPath,
 } from "../../util/routeUtil"
 import { renderInlineMarkup } from "../../util/languageUtil"
+import { setSiteAlertMessage } from "../../components/SiteAlert"
 
 interface MyAccountProps {
   assetPaths: unknown
@@ -62,7 +63,8 @@ const MyAccount = (_props: MyAccountProps) => {
   const { profile, loading, initialStateLoaded } = React.useContext(UserContext)
 
   if (!profile && !loading && initialStateLoaded) {
-    // TODO: Redirect to React sign in page and show a message that user needs to sign in
+    window.sessionStorage.setItem("redirect", "account")
+    setSiteAlertMessage(t("signIn.loginRequired"), "secondary")
     window.location.href = getSignInPath()
     return null
   }

app/javascript/pages/account/my-applications.tsx

@@ -21,6 +21,7 @@ import "./styles/my-applications.scss"
 import { DoubleSubmittedModal } from "./components/DoubleSubmittedModal"
 import { AlreadySubmittedModal } from "./components/AlreadySubmittedModal"
 import { extractModalParamsFromUrl } from "./components/util"
+import { setSiteAlertMessage } from "../../components/SiteAlert"
 
 export const noApplications = () => {
   return (
@@ -198,6 +199,8 @@ const MyApplications = () => {
   }, [authLoading, initialStateLoaded, profile])
 
   if (!profile && !authLoading && initialStateLoaded) {
+    window.sessionStorage.setItem("redirect", "applications")
+    setSiteAlertMessage(t("signIn.loginRequired"), "secondary")
     window.location.href = getSignInPath()
     return null
   }

app/javascript/util/routeUtil.ts

@@ -75,3 +75,21 @@ export const getEligibilityEstimatorLink = localizedPathGetter("/eligibility-est
 // Footer
 export const getDisclaimerPath = localizedPathGetter("/disclaimer")
 export const getPrivacyPolicyPath = localizedPathGetter("/privacy")
+
+const SignInRedirects = {
+  account: getMyAccountPath(),
+  applications: getMyApplicationsPath(),
+  settings: getMyAccountSettingsPath(),
+  home: getHomepagePath(),
+}
+
+const getRedirectUrl = (key: string): string => {
+  return SignInRedirects[key] || SignInRedirects.home
+}
+
+export const getSignInRedirectUrl = () => {
+  const redirect = window.sessionStorage.getItem("redirect")
+  window.sessionStorage.removeItem("redirect")
+
+  return getRedirectUrl(redirect || "account")
+}