feat: DAH-3043 Analytics for Application Flow #2448
Conversation
chadbrokaw
force-pushed
the
DAH-3043_measure_app_submission_time
branch
from
975d2ab to
e868bee
Compare
chadbrokaw
force-pushed
the
DAH-3043_measure_app_submission_time
branch
from
e868bee to
6ec2a35
Compare
chadbrokaw
requested review from
a team,
tallulahkay and
cade-exygy
and removed request for
a team
| @@ -1,5 +1,5 @@ | |||
| .back-link-container.small-only-text-center ng-if="rememberedShortFormState" | |||
| a.back-link ui-sref="{{rememberedShortFormState}}" | |||
| a.back-link(ui-sref="{{rememberedShortFormState}}" ng-click="logBackLinkClick()") | |||
There was a problem hiding this comment.
thought: I wonder about how useful this will be.
- create-account: the button is clicked when the applicant starts creating an account, but changes their mind and goes back to the application
- sign-in: this now defaults to the React version of the page
- forgot-password: the button is clicked when the button to reset their password, then click back to the application
There was a problem hiding this comment.
@jimlin-sfgov Tenley can distinguish on her end where the user is coming from because the data sent to google analytics includes the origin url cc: @chadbrokaw
| @@ -136,6 +136,9 @@ | |||
| onConfirm: -> | |||
| # fires only if user clicks 'ok' to leave page | |||
| # reloads this stateChangeStart method with skipConfirm true | |||
| AnalyticsService.trackApplicationAbandon(ShortFormApplicationService.listing.listingID, null, "Leaving for " + toState.name) | |||
| $window.removeEventListener('unload', $rootScope.onUnload) | |||
|
|
|||
There was a problem hiding this comment.
question: When leaving an application, we show either the Angular modal or the browser dialog. We seem to be showing the browser dialog in most cases now, because users are navigating to a non-Angular page. Does this cover the browser dialog scenario?
There was a problem hiding this comment.
Yes! The browser dialog situation is covered by the onUnload handler that I added
| @@ -620,6 +620,7 @@ | |||
|
|
|||
| if ShortFormApplicationService.application.status == 'Submitted' | |||
| # send them to their review page if the application is already submitted | |||
| AnalyticsService.trackApplicationAbandon(listing.Id, AccountService.loggedInUser?.id || null, "Application already submitted") | |||
There was a problem hiding this comment.
Question: Why would there ever not be an id here?
| @@ -6,27 +6,38 @@ AnalyticsService = ($state) -> | |||
| Service = {} | |||
| Service.timer = {} | |||
|
|
|||
| Service.resetProperties = { | |||
There was a problem hiding this comment.
Should this object have any values?
There was a problem hiding this comment.
Not currently, there may be some values we want to nullify in the future though so I left the empty object in there
| doubleSubmit = !! $scope.appIsSubmitted($scope.application) | ||
| if $window.ACCOUNT_INFORMATION_PAGES_REACT is "true" | ||
| currentUrl = window.location.origin | ||
| newUrl = "#{currentUrl}/my-applications?" | ||
| if previousApp.id | ||
| AnalyticsService.trackApplicationAbandon($scope.listing.Id, AccountService.loggedInUser?.id || null, 'Already Submitted') |
There was a problem hiding this comment.
Same here, why would the id ever be null?
There was a problem hiding this comment.
It shouldn't ever be null, I added the check just to be 100% sure
| newUrl += "alreadySubmittedId=#{previousApp.id}" | ||
| if doubleSubmit | ||
| newUrl += "&" | ||
| if doubleSubmit | ||
| # As we rebuilt the My Applications page in React we were not able to figure out a way to trigger the Double Submit Modal. | ||
| # We are leaving the code here both to document past behavior and to protect the application in case somehow the modal is triggered | ||
| AnalyticsService.trackApplicationAbandon($scope.listing.Id, AccountService.loggedInUser?.id || null, 'Double Submitted') |
There was a problem hiding this comment.
This has not been triggered right? Only there to cover our bases?
There was a problem hiding this comment.
Yes! I honestly added this for me to see if it is ever being triggered, based on my exploration of the code this situation should never occur
There was a problem hiding this comment.
This looks great! I'm comfortable moving forward with it and updating as needed. It seems to me that it covers all the situations you laid out.
My main question is about allowing a null id - in the cases I pointed out, it seems like not having a user id would indicate a bug.
chadbrokaw
force-pushed
the
DAH-3043_measure_app_submission_time
branch
from
ed1d817 to
39af3e7
Compare
Description
This PR adds in logging for the application flow including application start, application abandon, and application complete.
Jira ticket
DAH-3043
Checklist before requesting review
Version Control
angularif it contains updates to Angular codetype: TICKET-NUMBER Descriptionformat, e.g.feat: DAH-123 New FeatureCode quality
Review instructions
Request review
needs reviewlabelHousing Enggroup to automatically assign reviewers, and/or assign specific engineers