Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-2661 New Nav Bar! #2464

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

tallulahkay
Copy link
Contributor

@tallulahkay tallulahkay commented Dec 17, 2024

Description

Adds a new nav bar!

Jira ticket

https://sfgovdt.jira.com/browse/DAH-2661

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 01:16 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 18:09 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 19:01 Inactive
@tallulahkay tallulahkay force-pushed the DAH-2661-new-directory-nav-bar branch from faa924e to 4912d9b Compare December 17, 2024 23:07
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 23:07 Inactive
@tallulahkay tallulahkay changed the base branch from main to DAH-2660-new-directory-section-headers December 17, 2024 23:13
@tallulahkay tallulahkay force-pushed the DAH-2661-new-directory-nav-bar branch from 4912d9b to 6e9eb3e Compare December 17, 2024 23:14
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 23:14 Inactive
<main
data-testid="main-content-test-id"
id="main-content"
className="md:overflow-x-hidden"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewer: I removed this and did some regression testing and it doesn't seem to affect anything! Let me know if you find something otherwise

@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 23:38 Inactive
@tallulahkay tallulahkay force-pushed the DAH-2661-new-directory-nav-bar branch from 97f9390 to 23f24a7 Compare December 17, 2024 23:41
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 23:41 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 23:44 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 17, 2024 23:47 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 00:09 Inactive
@tallulahkay tallulahkay force-pushed the DAH-2661-new-directory-nav-bar branch from cfe940e to 917c7d5 Compare December 18, 2024 00:17
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 00:17 Inactive
@tallulahkay tallulahkay force-pushed the DAH-2661-new-directory-nav-bar branch from 917c7d5 to 832d0cd Compare December 18, 2024 00:24
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 00:24 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 00:56 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 18:01 Inactive
Base automatically changed from DAH-2660-new-directory-section-headers to main December 18, 2024 18:14
@tallulahkay tallulahkay force-pushed the DAH-2661-new-directory-nav-bar branch from 66eb635 to 87c677d Compare December 18, 2024 18:17
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 18:17 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 18:21 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 18:44 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 21:43 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 22:11 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 18, 2024 23:21 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 19, 2024 22:52 Inactive
@tallulahkay tallulahkay changed the title feat: DAH-2661 nav bar WIP feat: DAH-2661 New Nav Bar! Dec 19, 2024
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2464 December 20, 2024 00:01 Inactive
@tallulahkay tallulahkay requested review from a team, chadbrokaw and jimlin-sfgov and removed request for a team December 20, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants