-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DAH-2661 New Nav Bar! #2464
Open
tallulahkay
wants to merge
26
commits into
main
Choose a base branch
from
DAH-2661-new-directory-nav-bar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallulahkay
force-pushed
the
DAH-2661-new-directory-nav-bar
branch
from
December 17, 2024 23:07
faa924e
to
4912d9b
Compare
tallulahkay
changed the base branch from
main
to
DAH-2660-new-directory-section-headers
December 17, 2024 23:13
tallulahkay
force-pushed
the
DAH-2661-new-directory-nav-bar
branch
from
December 17, 2024 23:14
4912d9b
to
6e9eb3e
Compare
tallulahkay
commented
Dec 17, 2024
<main | ||
data-testid="main-content-test-id" | ||
id="main-content" | ||
className="md:overflow-x-hidden" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewer: I removed this and did some regression testing and it doesn't seem to affect anything! Let me know if you find something otherwise
tallulahkay
force-pushed
the
DAH-2661-new-directory-nav-bar
branch
from
December 17, 2024 23:41
97f9390
to
23f24a7
Compare
tallulahkay
force-pushed
the
DAH-2661-new-directory-nav-bar
branch
from
December 18, 2024 00:17
cfe940e
to
917c7d5
Compare
tallulahkay
force-pushed
the
DAH-2661-new-directory-nav-bar
branch
from
December 18, 2024 00:24
917c7d5
to
832d0cd
Compare
Base automatically changed from
DAH-2660-new-directory-section-headers
to
main
December 18, 2024 18:14
tallulahkay
force-pushed
the
DAH-2661-new-directory-nav-bar
branch
from
December 18, 2024 18:17
66eb635
to
87c677d
Compare
tallulahkay
requested review from
a team,
chadbrokaw and
jimlin-sfgov
and removed request for
a team
December 20, 2024 23:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new nav bar!
Jira ticket
https://sfgovdt.jira.com/browse/DAH-2661
Checklist before requesting review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
Code quality
Review instructions
Request review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineers