Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3039 React dialog width #2465

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: DAH-3039 React dialog width #2465

wants to merge 3 commits into from

Conversation

cliu02
Copy link
Collaborator

@cliu02 cliu02 commented Dec 17, 2024

Description

Updates the timeout UIC Modal to use Seeds Dialog to match other React dialogs and set a max width.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3039

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2465 December 17, 2024 16:39 Inactive
@cliu02 cliu02 marked this pull request as ready for review December 17, 2024 18:35
@cliu02 cliu02 added the needs review Pull request needs review label Dec 17, 2024
@cliu02 cliu02 requested review from a team, chadbrokaw and cade-exygy and removed request for a team December 17, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants