fix angular tests #2466
Open
fix angular tests #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadbrokaw
requested review from
a team,
tallulahkay and
jimlin-sfgov
and removed request for
a team
chadbrokaw
commented
Dec 19, 2024
Comment on lines
9
to
+17
| Service.trackEvent = (event, properties) -> | ||
| dataLayer = window.dataLayer || [] | ||
| combinedProperties = Object.assign({}, Service.resetProperties, properties) | ||
| unless combinedProperties.label | ||
| unless properties.label | ||
| # by default, grab the end of the URL e.g. the "contact" from "/x/y/z/contact" | ||
| current_path = _.first(_.last($state.current.url.split('/')).split('?')) | ||
| combinedProperties.label = current_path | ||
| combinedProperties.event = event | ||
| combinedProperties.event_timestamp = new Date().toISOString(); | ||
| dataLayer.push(combinedProperties) | ||
| properties.label = current_path | ||
| properties.event = event | ||
| properties.event_timestamp = new Date().toISOString(); | ||
| dataLayer.push(properties) |
There was a problem hiding this comment.
I wanted to keep the resetProperties object around, but it was causing issues with the tests so I figured it was more trouble than it was worth
|
@chadbrokaw The tests are still failing, but it's because of a salesforce error! I've notified the Salesforce channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with a previous PR where tests where angular tests were failing.
To test, please pull down the branch and run
bundle exec rake jasmine:ciJira ticket
DAH-3043
Checklist before requesting review
Version Control
angularif it contains updates to Angular codetype: TICKET-NUMBER Descriptionformat, e.g.feat: DAH-123 New FeatureCode quality
Review instructions
Request review
needs reviewlabelHousing Enggroup to automatically assign reviewers, and/or assign specific engineers