Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3014 Fix undefined lottery preferences bug #2491

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Jan 9, 2025

Description

This PR fixes an issue where FCFS pages (or any pages where the listing had no preferences) crashed.

To test, go to any FCFS listing (e.g. /listings/a0WW4000000EOdZMAW) and make sure it loads.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3014

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2491 January 9, 2025 00:25 Inactive
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2491 January 9, 2025 00:26 Inactive
@chadbrokaw chadbrokaw added the needs review Pull request needs review label Jan 9, 2025
@chadbrokaw chadbrokaw requested review from cliu02, a team and tallulahkay and removed request for a team January 9, 2025 00:27
@chadbrokaw chadbrokaw merged commit 48b041a into main Jan 9, 2025
31 checks passed
@chadbrokaw chadbrokaw deleted the DAH-3014_fix_undefined_lottery_prefs branch January 9, 2025 15:48
chadbrokaw added a commit that referenced this pull request Jan 9, 2025
* fix: fix undefined lottery preferences

* fix: remove unnecessary optional chaining
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants