Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3176 hide directory 1.5 change #2508

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

tallulahkay
Copy link
Contributor

@tallulahkay tallulahkay commented Jan 17, 2025

Description

Makes sure sections are hidden unless there are listings, until directory 1.5.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3176

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2508 January 17, 2025 20:29 Inactive
@tallulahkay tallulahkay added the needs review Pull request needs review label Jan 17, 2025
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tallulahkay Were you planning to do a hotfix? If so, did you mean for the target branch to be main?

Edit: or merge to main, then cherrypick to release branch, then re-deploy? I forget if we settled on a new hotfix procedure. CC @alulabeshue-sfgov

@alulabeshue-sfgov
Copy link
Contributor

LGTM

@tallulahkay Were you planning to do a hotfix? If so, did you mean for the target branch to be main?

Edit: or merge to main, then cherrypick to release branch, then re-deploy? I forget if we settled on a new hotfix procedure. CC @alulabeshue-sfgov

We landed on treating a hotfix like any other feature change. I think we can merge this back into main and start a new release, even though it is a single change.

@jimlin-sfgov jimlin-sfgov merged commit 6d35c4d into main Jan 21, 2025
33 checks passed
@jimlin-sfgov jimlin-sfgov deleted the DAH-3176-directory-page-empty-state-hidden branch January 21, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants