Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-3080 DALP for My Applications page #2509

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cliu02
Copy link
Collaborator

@cliu02 cliu02 commented Jan 22, 2025

Description

Customize application item on My Applications page for DALP applications.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3080

Checklist before requesting review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly
  • if the changes include human translations, follow the human translations process

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2509 January 22, 2025 18:10 Inactive
@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2509 January 22, 2025 20:05 Inactive
@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2509 January 22, 2025 20:27 Inactive
@cliu02 cliu02 marked this pull request as ready for review January 22, 2025 20:36
@cliu02 cliu02 added the needs review Pull request needs review label Jan 22, 2025
@cliu02 cliu02 requested review from a team, chadbrokaw and tallulahkay and removed request for a team January 22, 2025 20:36
@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2509 January 22, 2025 20:43 Inactive
@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2509 January 22, 2025 20:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants