Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3181 Handle invalid listings when logging translation usage #2510

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

jimlin-sfgov
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov commented Jan 22, 2025

Description

Handle invalid listings when logging translation usage

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3181

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2510 January 22, 2025 20:44 Inactive
@jimlin-sfgov jimlin-sfgov requested review from a team, chadbrokaw, tallulahkay, alulabeshue-sfgov and cade-exygy and removed request for a team and tallulahkay January 22, 2025 21:02
@jimlin-sfgov jimlin-sfgov marked this pull request as ready for review January 22, 2025 21:03
Copy link
Contributor

@alulabeshue-sfgov alulabeshue-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! This now redirects home, instead of erroring out and hanging.

@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2510 January 22, 2025 22:44 Inactive
@jimlin-sfgov jimlin-sfgov merged commit f3905af into main Jan 22, 2025
17 of 18 checks passed
@jimlin-sfgov jimlin-sfgov deleted the DAH-3181-translate-logging-invalid-ids branch January 22, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants