Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of load_model parameters addresses #23 #31

Merged
merged 11 commits into from
Feb 4, 2025
Merged

Change of load_model parameters addresses #23 #31

merged 11 commits into from
Feb 4, 2025

Conversation

hzavadil98
Copy link
Contributor

Changing the parameter of load_model function to include the whole shape of the image so that the models were applicable on different datasets. #23 (Also contains my implementation of dataset and model which have not been merged before)

environment.yml Outdated Show resolved Hide resolved
@hzavadil98 hzavadil98 marked this pull request as ready for review February 4, 2025 10:00
@salomaestro
Copy link
Contributor

Nice! I'll pull this branch and update my dataloader with your new change, then push that to this branch.

@salomaestro
Copy link
Contributor

Also, to pass the Format Run ruff and isort github action, just run ruff format utils, then isort format utils in your terminal or vscode, and commit those changes.

@hzavadil98
Copy link
Contributor Author

What a mess 🤦‍♀️ @Johanmkr can you maybe also update your model based on this branch before we merge your pull request?

@salomaestro
Copy link
Contributor

@hzavadil98 Good job! I adjusted my model accordingly. We can wait for @Johanmkr to push his modifications before merging the PR.

@hzavadil98
Copy link
Contributor Author

@salomaestro Thanks for the formatting tips 👌 yeah let's wait for him

@salomaestro salomaestro mentioned this pull request Feb 4, 2025
Johanmkr added a commit that referenced this pull request Feb 4, 2025
@Johanmkr
Copy link
Contributor

Johanmkr commented Feb 4, 2025

@hzavadil98 @salomaestro Good job, I have updated my model and pushed.

@salomaestro
Copy link
Contributor

I can try to go through the conflicts

@salomaestro salomaestro merged commit 07a4ede into main Feb 4, 2025
1 check passed
@hzavadil98 hzavadil98 deleted the Jan branch February 5, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants