Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update tutorial about threads #177

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/update tutorial about threads #177

wants to merge 9 commits into from

Conversation

frayien
Copy link

@frayien frayien commented Feb 1, 2024

Related to #127.
As discussed in SFML/SFML#2892 and on Discord,

  • Add comments about thread safety in relevant part of the tutorials and in the FAQ.
  • Update comment about not needing to use sf::RenderWindow#setActive for coherency with previously modifier example.
  • Fixing a link in the French tutorial redirected to English version.

@frayien
Copy link
Author

frayien commented Feb 1, 2024 •
edited
Loading

Commits are not squashed, I assume it is done at PR acceptation ? (commit names are not the best lol)

kimci86
kimci86 reviewed Feb 1, 2024
View reviewed changes
tutorials/2.6/system-thread.php Outdated Show resolved Hide resolved
tutorials/2.6/system-thread-fr.php Outdated Show resolved Hide resolved
tutorials/2.6/graphics-draw.php Outdated Show resolved Hide resolved
@frayien
Copy link
Author

frayien commented Feb 2, 2024

Changed "instances of SFML's classes" to "SFML objects"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimci86 kimci86 kimci86 left review comments

@Marioalexsan Marioalexsan Marioalexsan approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frayien @kimci86 @Marioalexsan @eXpl0it3r