Unify all size_t arguments to use UIntPtr #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses SFML#212 * Updated to use a SIZE_T "macro" where CSFML is expecting `size_t` * `using SIZE_T = UIntPtr;` is at the beginning of each file that will P/Invoke functions with `size_t` signatures * SIZE_T is currently typedef'd to `UIntPtr` but this can be changed when `nuint` becomes available to SFML.NET (.NET 5+) * Since all changes are within protected/private code, this should not represent a breaking change for end-users * Implemented Font(byte[]) properly using sfFont_createFromMemory() instead of creating a new MemoryStream
|
Superseded by #253 Still appreciate the work! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #212
Updated to use a
SIZE_T"typedef" where CSFML is expectingsize_tusing SIZE_T = UIntPtr;is at the beginning of each file that will P/Invoke functions withsize_tsignaturesSIZE_Tis currently typedef'd toUIntPtrbut this can be changed whennuintbecomes available to SFML.NET (.NET 5+)Since all changes are within protected/private code, this should not represent a breaking change for end-users
Implemented Font(byte[]) properly using sfFont_createFromMemory() instead of creating a new MemoryStream