replace project name with ${PROJECT_NAME}

[L0laapk3]

Should speak for itself

[ChrisThrasher]

Repeat of #32

[L0laapk3]

Whoops

[vittorioromeo]

@ChrisThrasher can you provide the rejection rationale? I still think it's a worthwhile change.

[eXpl0it3r]

I believe it's the wrong approach as well, because we're mixing two things here, project and target.

Yes it works for this case, but we're teaching a wrong idea, that a project is target or a target is a project, which is not the case.

Maybe there's a middle ground of using a variable for the target name?

[vittorioromeo]

I see, thanks for explaining, @eXpl0it3r.

but we're teaching a wrong idea, that a project is target or a target is a project, which is not the case

I'd argue we are making the same mistake even before this PR then :)

[Bromeon]

I'd argue we are making the same mistake even before this PR then :)

That was my thinking as well -- if those are two different things, would it not be clearer to name them differently (even if they happen to have the same value)?

[ChrisThrasher]

can you provide the rejection rationale?

You're asking to write the CMake equivalent of this C++ code.

#define CAT_NAME Poe

struct Cat { int i; };

int main() {
    Cat CAT_NAME;
} 

In C++ when we want to reference something, we just spell out the variable name. We don't abstract that variable name behind a macro. To do the same in such a CMake project is way overkill and promotes a practice that scales very poorly to larger codebases.

I think the simplest solution is to rename the executable to main or something similarly terse. See #44.