CXX_STD = CXX11 removed

SGDinference-Lab · Oct 30, 2023 · be1105f · be1105f
1 parent 2969876
commit be1105f
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/src/Makevars b/src/Makevars
@@ -8,7 +8,9 @@
 ##
 ## And with R 3.4.0, and RcppArmadillo 0.7.960.*, we turn C++11 on as OpenMP
 ## support within Armadillo prefers / requires it
-CXX_STD = CXX11
+## The following is commented out to avoid the note 
+## "Specified C++11: please drop specification unless essential""
+## CXX_STD = CXX11
 
 PKG_CXXFLAGS = $(SHLIB_OPENMP_CXXFLAGS) 
 PKG_LIBS = $(SHLIB_OPENMP_CXXFLAGS) $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS)
diff --git a/src/Makevars.win b/src/Makevars.win
@@ -8,7 +8,9 @@
 ##
 ## And with R 3.4.0, and RcppArmadillo 0.7.960.*, we turn C++11 on as OpenMP
 ## support within Armadillo prefers / requires it
-CXX_STD = CXX11
+## The following is commented out to avoid the note 
+## "Specified C++11: please drop specification unless essential""
+## CXX_STD = CXX11
 
 PKG_CXXFLAGS = $(SHLIB_OPENMP_CXXFLAGS) 
 PKG_LIBS = $(SHLIB_OPENMP_CXXFLAGS) $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS)
diff --git a/tests/testthat/test-sgd_lm.R b/tests/testthat/test-sgd_lm.R
@@ -62,3 +62,30 @@ test_that("sgd_lm bt_start matters", {
   check = max(abs(out1$coefficients - out2$coefficients))
   expect_false(check==0)
 })
+
+test_that("sgd_lm burn matters 1", {
+  n = 1e05
+  p = 5
+  bt0 = rep(5,p)
+  x = 2*matrix(rnorm(n*(p-1)), n, (p-1))
+  y = cbind(1,x) %*% bt0 + rnorm(n)
+  my.dat = data.frame(y=y, x=x)
+  out1 = sgd_lm(y~., data=my.dat)
+  out2 = sgd_lm(y~., data=my.dat, burn=100)
+  check = max(abs(out1$coefficients - out2$coefficients))
+  expect_false(check==0)
+})
+
+test_that("sgd_lm burn matters 2", {
+  n = 1e05
+  p = 5
+  bt0 = rep(5,p)
+  x = 2*matrix(rnorm(n*(p-1)), n, (p-1))
+  y = cbind(1,x) %*% bt0 + rnorm(n)
+  my.dat = data.frame(y=y, x=x)
+  out1 = sgd_lm(y~., data=my.dat, studentize=FALSE)
+  out2 = sgd_lm(y~., data=my.dat, burn=100, studentize=FALSE)
+  check = max(abs(out1$coefficients - out2$coefficients))
+  expect_false(check==0)
+})
+