Feat/user #1
Merged
Feat/user #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dujiajun
reviewed
Aug 10, 2024
router.go
Outdated
| @@ -47,9 +47,13 @@ func registerRouter(r *gin.Engine) { | |||
| userGroup := needAuthGroup.Group("/user") | |||
| userGroup.GET("", handler.GetUserListHandler) | |||
| userGroup.GET("/suggest", handler.GetSuggestedUserHandler) | |||
| userGroup.GET("/me", handler.GetCurrentUserHandler) | |||
| userGroup.GET("/:userID", handler.GetUserDetailHandler) | |||
| userGroup.GET("/me", handler.GetCurrentUserSummaryHandler) | |||
There was a problem hiding this comment.
前端个人页面的概览部分其他用户是否被允许访问？对应GetCurrentUserSummaryHandler
有这些数据：
export type UserSummaryProps = {
review_count: number;
like_receive: number;
tip_receive: number;
following_course_count: number;
};如果允许的话我就改一下，或者加个鉴权？
There was a problem hiding this comment.
我暂时设置为了不允许访问，加了鉴权
export type UserDetailProps = {
id: number;
username: string;
avatar: string;
bio: string;
};允许访问
export type UserProfileProps = {
id: number;
user_id: number;
username: string;
bio: string;
email: string;
avatar: string;
role: string;
department: string;
major: string;
grade: string;
}不允许访问
There was a problem hiding this comment.
需要鉴权的，本人和第三方视角的内容是不一样的。先这样吧，后面再调。
|
别的没啥问题了，rebase 一下 main 然后过 ci 吧 |
…onverter functions
…rGroup in route.go
…ion for filter in \service\user.go
…ailHandler and GetUserViewsHandler in \handler\user.go which are partially declared in commit bcba52e
… according to jcourse_v2_frontend model.ts
…feature to repository/user.go
- Renamed routes in userGroup - Added a new '/user' route in adminGroup for displaying the user list - Refined user-related handlers to improve readability - Implemented authentication checks across user-related endpoints
…UserSummaryDTO func which caused cycle import
…function parameter in repository/user.go from value to reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the user routes, implemented most of the handlers(except watch/unwatch feature) related to the user feature, revised user DTO models according to the frontend model fields and expanded the functionality of repository/user.go