Feat/statistic #11
Merged
Feat/statistic #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
相关代码都在middleware/statistic.go 和middleware/statistic_test.go |
|
和这个需求本身无关的代码有点多啊，要不重新从main切出来，不然diff看着累 |
dujiajun
reviewed
Nov 11, 2024
|
merge了main |
|
再补下落表和生成报表的部分吧。我想要一个类似 discourse 的看板，日uv/pv，7天内，30天内，日活/月活比例等。 |
…re v1. Test Added. Bug Fixed Feature: 1. statistic middleware and task are main changes. Can get user, review, course daily adds and total counts and UV, PV, DAU, WAU, MAU efficiently. 2. save statistic data and statistic counts to db 3. add basic tests of statistics. 4. build simple test framewark for statistic, refactor the middleware 5. fix some previous bug on repository
|
写了一个比较完整的版本 |
|
没来得及细看，代码里的 magic number 都处理一下，我记得 golang 的 times 包里有常量定义 |
dujiajun
reviewed
Nov 16, 2024
(lack enough test for queue and full-chain api) 1. refactor task queue with asynq serveMux and Scheduler 2. refactor statistic related api 3. get timezone from env(see timeutil.go)
Merged
dujiajun
reviewed
Nov 20, 2024
|
其他应该没啥问题了 |
|
那个llm相关的问题我建了一个fix 分支pr了，那个分支是在main上建的，是在那里合了还是在这个分支合 |
change the GetPeriodInfoFromPOs method. add basic tests.
|
另外起一个pr没问题，在那边合吧 |
|
现在model和po的Date都是yyyy-mm-dd |
dujiajun
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前只是一个简单的框架， 只统计了UV/PV
只有基础的测试
现在还没有做存DB的部分，中间件也没有并入router，所以对原来的代码没有影响
仅是review用pr