-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WinUI 3 support #35
WinUI 3 support #35
Conversation
I don't know if it still builds if VS 2022 isn't installed with support for Desktop Apps. It definitely needs the Windows SDK and the correct version of it too...
Hello, @fubar-coder Can you also include a github actions script changes to support auto building library for auto publishing on nuget on icons change? |
Adding a The build environment needs an installed Win 10 SDK (including the UAP platform stuff), which means that the build must(?) be run under windows, using the - for example - ChristopheLav/windows-sdk-install build action, but I haven't tested it yet. |
Yep, current build environment is already on windows, since i also need to build WPF library, so probably windows not a problem here. But i also doesn't success while trying to setup CI build under windows, so probably it also should be in scope of this PR. |
@SKProCH Can you approve the workflow? It'd help testing the workflow 😀 |
@SKProCH PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to lower the required SDK version to 10.0.18362.0, because 10.0.22621.0 seems too high. There are still some Win10 machines out there 😄
Rx.NET still needs this API level
Feed free to do it, if it would work. |
The package requires the SDK version 10.0.18362.0, while the demo application requires 10.0.19041.0, due to its reliance on Rx.NET. EDIT: The CI should work fine though, because it only builds the icon package, not the demo apps. |
This tries to fix #31, but is blocked due to microsoft/microsoft-ui-xaml#9959.
This PR contains a fully functional DLL and demo application, which are mostly copies from the WPF implementation.
Differences from the WPF implementation include:
Data
property returns aGeometry
object nowRequirements:
TODO