Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI 3 support #35

Merged
merged 12 commits into from
Sep 7, 2024
Merged

WinUI 3 support #35

merged 12 commits into from
Sep 7, 2024

Conversation

fubar-coder
Copy link
Contributor

@fubar-coder fubar-coder commented Sep 7, 2024

This tries to fix #31, but is blocked due to microsoft/microsoft-ui-xaml#9959.

This PR contains a fully functional DLL and demo application, which are mostly copies from the WPF implementation.

Differences from the WPF implementation include:

  • The Data property returns a Geometry object now

Requirements:

  • .NET SDK 8.0.401
  • VS 2022 17.11.2

TODO

I don't know if it still builds if VS 2022 isn't installed with support for Desktop Apps. It definitely needs the Windows SDK and the correct version of it too...
@SKProCH SKProCH added the enhancement New feature or request label Sep 7, 2024
@SKProCH
Copy link
Owner

SKProCH commented Sep 7, 2024

Hello, @fubar-coder

Can you also include a github actions script changes to support auto building library for auto publishing on nuget on icons change?

@fubar-coder
Copy link
Contributor Author

Adding a EnableMsixTooling property fixes a part of the problems I encountered. The missing Platform.xml might be a bug in CsWinRT (microsoft/CsWinRT#1736).

The build environment needs an installed Win 10 SDK (including the UAP platform stuff), which means that the build must(?) be run under windows, using the - for example - ChristopheLav/windows-sdk-install build action, but I haven't tested it yet.

@SKProCH
Copy link
Owner

SKProCH commented Sep 7, 2024

Yep, current build environment is already on windows, since i also need to build WPF library, so probably windows not a problem here. But i also doesn't success while trying to setup CI build under windows, so probably it also should be in scope of this PR.

@fubar-coder
Copy link
Contributor Author

@SKProCH Can you approve the workflow? It'd help testing the workflow 😀

@fubar-coder fubar-coder marked this pull request as ready for review September 7, 2024 14:27
@fubar-coder
Copy link
Contributor Author

@SKProCH PR is ready for review

@SKProCH SKProCH self-requested a review September 7, 2024 14:28
Copy link
Contributor Author

@fubar-coder fubar-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to lower the required SDK version to 10.0.18362.0, because 10.0.22621.0 seems too high. There are still some Win10 machines out there 😄

@SKProCH
Copy link
Owner

SKProCH commented Sep 7, 2024

Feed free to do it, if it would work.

@fubar-coder
Copy link
Contributor Author

fubar-coder commented Sep 7, 2024

The package requires the SDK version 10.0.18362.0, while the demo application requires 10.0.19041.0, due to its reliance on Rx.NET.

EDIT: The CI should work fine though, because it only builds the icon package, not the demo apps.

@fubar-coder fubar-coder changed the title WIP: WinUI 3 support WinUI 3 support Sep 7, 2024
@SKProCH SKProCH merged commit 5557e08 into SKProCH:master Sep 7, 2024
1 check passed
@fubar-coder fubar-coder deleted the feature/winui branch September 8, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winui 3
2 participants