Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amrfinder parser is not seperating resistance variants from genes #115

Conversation

mhkc
Copy link
Collaborator

@mhkc mhkc commented Jan 21, 2025

This PR fixes an issue where the AmrFinder parser did not separate resistance variants from genes in its output. It also adds some test for the parser.

@mhkc mhkc added the bug Something isn't working label Jan 21, 2025
@mhkc mhkc requested a review from ryanjameskennedy January 21, 2025 15:04
@mhkc mhkc linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@mhkc mhkc force-pushed the 112-amrfinder-parser-is-not-seperating-resistance-variants-from-genes branch from b8780ae to 152e665 Compare January 24, 2025 14:10
@mhkc mhkc merged commit 4da20c0 into master Jan 24, 2025
7 checks passed
@mhkc mhkc deleted the 112-amrfinder-parser-is-not-seperating-resistance-variants-from-genes branch January 24, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMRfinder parser is not seperating resistance variants from genes.
2 participants