Add py script that generates master html #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkc
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
The report looks nice and works well. I approve the PR but please consider these thoughts,
- The order of the columns seems off to me. I would prefere that all QC related colums are next to one another.
- FastQC report is redundant since its included in the MultiQC report
- You could nest all NanoPlot results under the same main header. It could shorten the names and make the table more readable since you dont have to repeat NanoPlot. See below for an example
| Sample | NanoPlot | MultiQc | ||
|---|---|---|---|---|
| Plot 1 | Plot 2 | Plot 3 | ||
| Foo | Link 1 | Link 2 | Link 3 | QC link |
https://stackoverflow.com/questions/22702825/create-a-table-with-sub-headings-and-side-headings
|
Done! |
|
Looks nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.