Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnomad v4 #181

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Gnomad v4 #181

wants to merge 2 commits into from

Conversation

Jakob37
Copy link
Contributor

@Jakob37 Jakob37 commented Mar 22, 2024

Description

What is changed? What is the result of the changes?

fixes # (issue)

Type of change

  • Major change
  • Minor change
  • Patch
  • Documentation

Checklist:

  • My code follows the style guidelines for NF pipelines at CMD
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings (Keep an eye on .nextflow.log !)
  • I have updated the CHANGELOG
  • The latest commit in the master branch is tagged
    with the correct version number

Major change

  • Stub run completes without errors or new warnings
  • onco run finishes without any new warnings/errors and the results can
    be loaded into scout
  • wgs single run finishes without any new warnings/errors and the results
    can be loaded into scout
  • wgs trio run finishes without any new warnings/errors and the results
    can be loaded into scout
  • At least one other person has reviewed and approved my code
  • I have made corresponding changes to the documentation

Minor change

  • Stub run completes without errors or new warnings
  • onco run finishes without any new warnings/errors and the results can
    be loaded into scout
  • wgs single run finishes without any new warnings/errors and the results
    can be loaded into scout
  • wgs trio run finishes without any new warnings/errors and the results
    can be loaded into scout
  • At least one other person has reviewed and approved my code
  • I have made corresponding changes to the documentation

Patch

  • Stub run completes without errors or new warnings

[Optional] Are there any post-deployment tasks we need to perform?

  • Task/link to issue 1
  • Task/link to issue 2
  • ...

Instructions for the reviewers

How to test the changes

  1. Step 1
  2. Step 2

Expected outcome

[Optional] Additional information

Review

Review performed by:

  • Reviewer 1: Name1, (@Github_handle1)
  • Reviewer 2: Name1, (@Github_handle2)
  • ...

Testing performed by:

  • Name, (@Github_handle)
  • ...

Post-merge

  • The master branch has been tagged with the new version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant