Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat/#177-moment-post] 순간포착 게시물 업로드 #183

Merged
merged 7 commits into from
Feb 15, 2025

Conversation

5jisoo
Copy link
Member

@5jisoo 5jisoo commented Feb 9, 2025

📒 개요

블루투스 기능으로 업로드하는 순간포착 게시물 업로드 기능을 구현하였습니다.

📍 Issue 번호

🛠️ 작업사항

  • 게시물 업로드 api 변경
  • 순간포착 알람 전송

🧰 추가 논의사항

  • 공통 팔로워를 가져오는 부분을 비동기, 페이징 방식으로 처리하였습니다.

@5jisoo 5jisoo added the 🛠️ enhancement New feature or request label Feb 9, 2025
@5jisoo 5jisoo self-assigned this Feb 9, 2025
Copy link

Overall Project 65.48% -1.12% 🍏
Files changed 58.05%

File Coverage
FollowRepository.java 100% 🍏
AsyncConfig.java 100% 🍏
TagService.java 95.79% -4.21%
Post.java 91.04% 🍏
AlarmType.java 90.82% 🍏
PostService.java 87.96% -1.68% 🍏
PostAlarm.java 57% -43%
PostImageDeletionScheduler.java 27.91% 🍏
PostAlarmService.java 20.69% -79.31%
Constant.java 0% 🍏

Copy link

Overall Project 66.24% -0.37% 🍏
Files changed 86.13% 🍏

File Coverage
TagService.java 100% 🍏
PostAlarmService.java 100% 🍏
FollowRepository.java 100% 🍏
AsyncConfig.java 100% 🍏
Post.java 91.04% 🍏
AlarmType.java 90.82% 🍏
PostService.java 89.64% 🍏
PostAlarm.java 67% -33% 🍏
PostImageDeletionScheduler.java 27.91% 🍏
Constant.java 0% 🍏

validateInvalidMemberTag(taggedMemberHandleList, taggedMemberList, image);
List<String> taggedMemberHandleList = request.getAllTaggedMember();
List<Member> taggedMemberList = memberRepository.findMemberByHandleList(taggedMemberHandleList, loginMember);
validateInvalidMemberTag(taggedMemberHandleList, taggedMemberList);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate를 하면 pinnedMember도 검증이되니까 먼저 호출하고, taggedMemberList 순회해서 pinnedMember 찾아내는 건 별로일까요?

Member pinnedMember = taggedMemberList.stream().filter(f -> f.getHandle() == request.getPinnedHandle()) .findFirst().get(); 이런식으로..? 별거아니지만 리스트가 적으면 더 빠를수도있을거같아서 말해봅니당

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정완료~!

Copy link

Overall Project 66.24% -0.43% 🍏
Files changed 84.98% 🍏

File Coverage
TagService.java 100% 🍏
PostAlarmService.java 100% 🍏
FollowRepository.java 100% 🍏
AsyncConfig.java 100% 🍏
Post.java 91.04% 🍏
AlarmType.java 90.82% 🍏
PostService.java 88.71% -1.34% 🍏
PostAlarm.java 67% -33% 🍏
PostImageDeletionScheduler.java 27.91% 🍏
Constant.java 0% 🍏

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@5jisoo 5jisoo merged commit d7174c6 into develop Feb 15, 2025
1 of 2 checks passed
@5jisoo 5jisoo deleted the feat/#177-moment-post branch February 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants