Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor/#187-image-url] 이미지 파일 저장방식 변경 #188

Merged
merged 4 commits into from
Feb 15, 2025

Conversation

5jisoo
Copy link
Member

@5jisoo 5jisoo commented Feb 12, 2025

📒 개요

프로필 / 게시물 이미지 파일 저장방식을 변경하였습니다.

📍 Issue 번호

🛠️ 작업사항

  • 회원 사진 업데이트 오류 수정
  • url 저장위치 변경

Copy link

Overall Project 65.95% -0.69% 🍏
Files changed 29.76%

File Coverage
PostService.java 89.43% 🍏
Post.java 88.24% 🍏
Member.java 72.59% -1.48%
OAuthService.java 12.66% -13.5%
MemberService.java 8.14% -8.14%
CloudStorageService.java 3.21% -2.67%

member.getHandle()
);
member.updateProfileImage(profileImageUrl);
}
Copy link
Collaborator

@yeahjinjeong yeahjinjeong Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 방식(이미지 저장 -> 멤버 저장)에 문제가 있었나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

블루투스 호출에서 일정 바이트 이상 전달이 불가능해서 기존 사진 파일 url전달이 불가능했어요!
그래서 member handle만으로 해당 멤버의 프로필 사진이 유추가능하도록 수정했슴다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insert 쿼리 호출 한번으로 수정하였습니닷~~

Copy link

Overall Project 65.95% -0.65% 🍏
Files changed 30.86%

File Coverage
PostService.java 89.43% 🍏
Post.java 88.24% 🍏
Member.java 72.59% -1.48%
OAuthService.java 12.66% -12.24%
MemberService.java 8.14% -8.14%
CloudStorageService.java 3.21% -2.67%

Copy link

Overall Project 66.42% -0.63% 🍏
Files changed 31.71%

File Coverage
PostService.java 88.83% 🍏
Post.java 87.68% 🍏
Member.java 72.59% -1.48%
OAuthService.java 12.66% -12.24%
MemberService.java 8.14% -8.14%
CloudStorageService.java 3.21% -2.67%

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
47.7% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@5jisoo 5jisoo merged commit 5a04efc into develop Feb 15, 2025
1 of 2 checks passed
@5jisoo 5jisoo deleted the refactor/#187-image-url branch February 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants