Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/#189-sort-comment] Comment 정렬 조건 추가하기 #190

Merged
merged 8 commits into from
Feb 24, 2025

Conversation

yeahjinjeong
Copy link
Collaborator

@yeahjinjeong yeahjinjeong commented Feb 15, 2025

📒 개요

댓글 정렬 조건 선택할 수 있게 pageable로 동적 쿼리 처리

📍 Issue 번호

🛠️ 작업사항

  • getComments
  • getChildCommentByParentComment

🧰 추가 논의사항

  • getComments 쿼리 재사용성이 떨어져서 리팩토링한다면 queryDSL로 해야 할듯요 .. 시간이 남는다면 차차하겠습니다

@yeahjinjeong yeahjinjeong changed the title [efactor: Comment pageable 정렬 조건으로 쿼리 동적 처리 #189 [Refactor/#189-sort-comment] Comment 정렬 조건 추가하기 Feb 15, 2025
@yeahjinjeong yeahjinjeong requested a review from 5jisoo February 15, 2025 04:15
@yeahjinjeong yeahjinjeong self-assigned this Feb 15, 2025
Copy link
Member

@5jisoo 5jisoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이거 pageable 파라미터로 받는게 진짜 깔끔하네요

Copy link

Overall Project 66.51% 🍏
Files changed 100% 🍏

File Coverage
CommentService.java 70.36% 🍏
CommentRepository.java 58.33% 🍏

Copy link
Contributor

@dudrhy12 dudrhy12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쿼리 반복 부분이 많은데 이부분은 리팩토링 하면 좋을 것 같습니다! 그럼 서비스코드에서 조건문 쓰는 부분도 개선될 것 같아요~

Copy link

Overall Project 66.51% -0.09% 🍏
Files changed 80.49% 🍏

File Coverage
CommentService.java 70.63% -3.17% 🍏
CommentRepository.java 58.33% 🍏

Copy link

Overall Project 66.51% -0.09% 🍏
Files changed 82.22% 🍏

File Coverage
ListToPageConverter.java 91.43% 🍏
CommentService.java 70.63% -3.17% 🍏
CommentRepository.java 58.33% 🍏

Copy link

Overall Project 66.52% -0.07% 🍏
Files changed 84.62% 🍏

File Coverage
CommentService.java 71.2% -2.4% 🍏
CommentRepository.java 58.33% 🍏

Copy link

Overall Project 66.52% -0.07% 🍏
Files changed 84.62% 🍏

File Coverage
CommentService.java 71.2% -2.4% 🍏
CommentRepository.java 58.33% 🍏

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.8% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@yeahjinjeong yeahjinjeong merged commit 5ff7a11 into develop Feb 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants