Try to make some complex queries work in ODBC backend #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe the statement once again after calling execute() if we had failed to describe it before because SQLNumResultCols() returned 0, as it may happen with some complex queries and SQL Server used via ODBC backend. Closes SOCI#1151. See SOCI#1182. Co-Authored-By: Vadim Zeitlin <[email protected]>
vadz
force-pushed
the
odbc-complex-query
branch
from
6cca369 to
48a5a6c
Compare
It looks like this function must always be called after a (successful) call to describe() and it is not called from anywhere else, so it seems wrong to both require and allow calling it independently -- just call it from describe() itself. No real changes, this function has never been part of public API, so hopefully nobody was using it.
|
@joshua-vanitha-15639 Please let me know if you have any comments, otherwise I'll merge this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the statement once again after calling execute() if we had failed to describe it before because SQLNumResultCols() returned 0.