Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark for #ifNil:, #ifNotNil:, #ifNil:ifNotNil:, and #ifNotNil:ifNil: #124

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

smarr
Copy link
Member

@smarr smarr commented Feb 17, 2025

This is a microbenchmark for the methods introduced in #123.
The main purpose is to track whether these methods are inlined in interpreters.

Also:

  • improve tests
  • update GitHub Actions setup

@smarr smarr added the enhancement Improves the implementation with something noteworthy label Feb 17, 2025
- make test less ambiguous around semantics of receiver being returned from Object>>#ifNil:
- change order to make the output of exected and actual match

Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
@smarr smarr merged commit 1daeec7 into SOM-st:master Feb 20, 2025
6 checks passed
@smarr smarr deleted the if-nil-benchmark branch February 20, 2025 17:51
smarr added a commit to SOM-st/SOMpp that referenced this pull request Feb 20, 2025
Adopts the changes of SOM-st/SOM#123 and
SOM-st/SOM#124.

This does not add any changes in SOM++ itself though.
They are separate in #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the implementation with something noteworthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant