Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#25 add my info api #26

Merged
merged 13 commits into from
Jul 9, 2023
Merged

Feat/#25 add my info api #26

merged 13 commits into from
Jul 9, 2023

Conversation

dong2ast
Copy link
Collaborator

@dong2ast dong2ast commented Jul 9, 2023

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

closed #25

โœจ ๊ณผ์ œ ๋‚ด์šฉ

  • ๋‚ด ์ •๋ณด GET ๋ฉ”์„œ๋“œ ์ถ”๊ฐ€
  • ๋‚ด ์ •๋ณด PATCH ๋ฉ”์„œ๋“œ ์ถ”๊ฐ€
  • ๋‚ด ์ •๋ณด ๊ด€๋ จ DTO ์ƒ์„ฑ
  • ์ƒ์ผ๊ณผ ์„ฑ๋ณ„ POST ๊ฐ€๋Šฅํ•œ ๋ฉ”์„œ๋“œ ์ถ”๊ฐ€

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

๐Ÿ“š ๋ ˆํผ๋Ÿฐ์Šค (๋˜๋Š” ์ƒˆ๋กœ ์•Œ๊ฒŒ ๋œ ๋‚ด์šฉ) ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

@dong2ast dong2ast requested a review from onpyeong July 9, 2023 02:16
@dong2ast dong2ast linked an issue Jul 9, 2023 that may be closed by this pull request
4 tasks
@dong2ast dong2ast self-assigned this Jul 9, 2023
Comment on lines +69 to +72
private Member getMemberById(Long memberId) {
return memberRepository.findById(memberId)
.orElseThrow(() -> new NotFoundException(ErrorStatus.NOT_FOUND_USER_EXCEPTION, ErrorStatus.NOT_FOUND_USER_EXCEPTION.getMessage()));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฉ”์„œ๋“œ ๋”ฐ๋กœ ๋นผ๋‹ˆ๊นŒ ์ข‹๋„ค์š”!๐Ÿ‘

@onpyeong onpyeong merged commit 42b33e2 into main Jul 9, 2023
@onpyeong onpyeong deleted the feat/#25-add-my-info-api branch July 9, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] ๋‚ด์ •๋ณด ๊ด€๋ฆฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„
2 participants