add: table 및 column 이름 관련 코드 변경 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onpyeong
reviewed
Jul 10, 2023
| @@ -28,7 +28,7 @@ public class MemberBooktalk extends AuditingTimeEntity { | |||
| // 연관 관계 편의 메서드 | |||
| public void setMember(Member member) { | |||
| if(this.member != null) { | |||
| this.member.getUserBookTalkList().remove(this); | |||
| this.member.getUserBookTalkList().remove(this); //이거 PATCH될 가능성이 있나? | |||
There was a problem hiding this comment.
-> 연관 관계 편의 메서드는 양방향일 때 사용하는 것
setMember를 할 때 member에 기존 member가 있을 수가 없음!
setBooktalk 역시 마찬가지
onpyeong
reviewed
Jul 10, 2023
| @@ -35,7 +34,7 @@ public class Place extends AuditingTimeEntity { | |||
|
|
|||
| private String placeImage; | |||
|
|
|||
| @OneToMany(mappedBy = "place") | |||
| @OneToMany(mappedBy = "place") // Booktalk리스트에 이 속성 요소를 넣고 하나로 통합하던, BooktalkPlace를 만드는게 나을 것 같은데? | |||
There was a problem hiding this comment.
approve와 pending 두 개의 리스트가 Booktalk와 중복으로 관계를 맺고 있기 때문에 리스트는 하나만 두고 Booktalk 내부의 속성으로 구분해주는 것으로 수정!
onpyeong
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ 과제 내용
테이블 및 컬럼 명 수정
📸 스크린샷(선택)
📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들