Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/#82 fix auditing #83

Merged
merged 9 commits into from
Aug 14, 2023
Merged

Add/#82 fix auditing #83

merged 9 commits into from
Aug 14, 2023

Conversation

dong2ast
Copy link
Collaborator

@dong2ast dong2ast commented Aug 9, 2023

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

closed #82

โœจ ๊ณผ์ œ ๋‚ด์šฉ

  • auditing ์‹œ์Šคํ…œ์— ์ƒ์„ฑ, ์ˆ˜์ • ๋‚ ์งœ ๋ฟ๋งŒ ์•„๋‹ˆ๋ผ ์ƒ์„ฑ, ์ˆ˜์ • User ์ •๋ณด๋„ ์ €์žฅํ•˜๊ฒŒ ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ํด๋” ๊ตฌ์กฐ ํ•œ๋ฒˆ ๋” ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. (์ž˜ ์•ˆ์“ฐ๋Š” ๊ฐ์ฒด๋ฅผ ํด๋” ์•ˆ์œผ๋กœ ๊ฐ์ท„์Šต๋‹ˆ๋‹ค.)
  • ๋ช‡๋ช‡ warning๋“ค ๋ฐœ์ƒํ•˜์ง€ ์•Š๊ฒŒ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

๐Ÿ“š ๋ ˆํผ๋Ÿฐ์Šค (๋˜๋Š” ์ƒˆ๋กœ ์•Œ๊ฒŒ ๋œ ๋‚ด์šฉ) ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

@dong2ast dong2ast added the ๊ฐœ๋ฐœ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ ํ–ˆ์„ ๋•Œ label Aug 9, 2023
@dong2ast dong2ast self-assigned this Aug 9, 2023
@dong2ast dong2ast linked an issue Aug 9, 2023 that may be closed by this pull request
2 tasks
Comment on lines +16 to +21
@CreatedBy
@Column(updatable = false)
private String createdBy;

@LastModifiedBy
private String lastModifiedBy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ƒ์„ฑ, ๋ณ€๊ฒฝ user ์ •๋ณด๋„ ์ €์žฅํ•  ์ˆ˜ ์žˆ๊ตฐ์š” ๊ตฟ๊ตฟ

@dong2ast dong2ast merged commit bea4040 into main Aug 14, 2023
1 check passed
@dong2ast dong2ast deleted the add/#82-fix-auditing branch August 14, 2023 00:14
dong2ast added a commit that referenced this pull request Aug 18, 2023
* refactor: oauth ๊ฐœ๋ฐœ ์ „ ํด๋” ๊ตฌ์กฐ ๋ฆฌํŒฉํ† ๋ง

* feat: oauth2 ๊ด€๋ จ ์ดˆ๊ธฐ ์„ค์ • ๋ฐ google ๋กœ๊ทธ์ธ ๊ตฌํ˜„ | member ๋„๋ฉ”์ธ ์—ฐ๊ฒฐ์— ๋Œ€ํ•œ ์„ธ๋ถ€์‚ฌํ•ญ์€ ์•„์ง ๊ตฌํ˜„ x

* feat: oauth ํšŒ์› ๊ฐ€์ž… ๋กœ์ง ๋ฐ ๋กœ๊ทธ์ธ ๋กœ์ง ๊ตฌํ˜„ | ํšŒ์› ๊ฐ€์ž… ํ›„ ์ถ”๊ฐ€์ •๋ณด ๋ฆฌ๋‹ค์ด๋ ‰ํŒ… ํ•„์š”

* feat: oauth ํšŒ์› ๊ฐ€์ž… ํ›„ ์ถ”๊ฐ€์ •๋ณด ์‚ฌ์ดํŠธ๋กœ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ ๋ฐ ํ† ํฐ ๋ฐ˜ํ™˜ ๋กœ์ง ๊ตฌํ˜„

* feat: Member ํ•„๋“œ์— social ID ํ•„๋“œ ์ถ”๊ฐ€ ๋ฐ ํ•ด๋‹น ๊ฐ’์œผ๋กœ ํšŒ์›๊ฐ€์ž… ์—ฌ๋ถ€ ์กฐํšŒ ๋กœ์ง ๊ตฌํ˜„ (๊ตฌ๊ธ€, ๋„ค์ด๋ฒ„, ์นด์นด์˜ค)

* feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ์‹คํŒจ handler ์ถ”๊ฐ€

* Add/#82 fix auditing (#83)

* add: dto์— valid message ์ถ”๊ฐ€

* add: controller์— valid ์˜ต์…˜ ์ถ”๊ฐ€

* refactor: ํด๋” ๊ตฌ์กฐ ๋ณ€๊ฒฝ

* add: ์—”ํ‹ฐํ‹ฐ์— ์ƒ์„ฑ ๋ฐ ์ˆ˜์ • User ๊ธฐ๋ก Auditing ์ถ”๊ฐ€

* refactor: ํด๋” ๊ตฌ์กฐ ๋ณ€๊ฒฝ

* fix: unchecked call to ~ warning ์ œ๊ฑฐ

* fix: ์ฝ”๋“œ์— ํƒ€์ž… ์บ์ŠคํŒ… ์ค‘๋ณต ์ œ๊ฑฐ

* fix: ์ฝ”๋“œ์— ํƒ€์ž… ์บ์ŠคํŒ… ์ค‘๋ณต ์ œ๊ฑฐ

* refactor: ์ฝ”๋“œ ๊ณ„์ธต ๊ตฌ์กฐ ๋ณ€๊ฒฝ

* refactor: oauth ๊ฐœ๋ฐœ ์ „ ํด๋” ๊ตฌ์กฐ ๋ฆฌํŒฉํ† ๋ง

* feat: oauth2 ๊ด€๋ จ ์ดˆ๊ธฐ ์„ค์ • ๋ฐ google ๋กœ๊ทธ์ธ ๊ตฌํ˜„ | member ๋„๋ฉ”์ธ ์—ฐ๊ฒฐ์— ๋Œ€ํ•œ ์„ธ๋ถ€์‚ฌํ•ญ์€ ์•„์ง ๊ตฌํ˜„ x

* feat: oauth ํšŒ์› ๊ฐ€์ž… ๋กœ์ง ๋ฐ ๋กœ๊ทธ์ธ ๋กœ์ง ๊ตฌํ˜„ | ํšŒ์› ๊ฐ€์ž… ํ›„ ์ถ”๊ฐ€์ •๋ณด ๋ฆฌ๋‹ค์ด๋ ‰ํŒ… ํ•„์š”

* feat: oauth ํšŒ์› ๊ฐ€์ž… ํ›„ ์ถ”๊ฐ€์ •๋ณด ์‚ฌ์ดํŠธ๋กœ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ ๋ฐ ํ† ํฐ ๋ฐ˜ํ™˜ ๋กœ์ง ๊ตฌํ˜„

* feat: Member ํ•„๋“œ์— social ID ํ•„๋“œ ์ถ”๊ฐ€ ๋ฐ ํ•ด๋‹น ๊ฐ’์œผ๋กœ ํšŒ์›๊ฐ€์ž… ์—ฌ๋ถ€ ์กฐํšŒ ๋กœ์ง ๊ตฌํ˜„ (๊ตฌ๊ธ€, ๋„ค์ด๋ฒ„, ์นด์นด์˜ค)

* feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ์‹คํŒจ handler ์ถ”๊ฐ€

* feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ์ „์šฉ ํšŒ์›๊ฐ€์ž… controller ์ƒ์„ฑ | ์ฒซ ์†Œ์…œ ๋กœ๊ทธ์ธ์‹œ ๋ฐœ๊ธ‰๋œ access token์„ ํ†ตํ•ด ๊ฒ€์ฆ

* fix: auditing ์—๋Ÿฌ ์ˆ˜์ •

* feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ํšŒ์›๊ฐ€์ž… ๊ธฐ๋Šฅ ๊ตฌํ˜„ (์ž„์˜๋กœ ๋งŒ๋“  ๊ฐ์ฒด์— ์ƒˆ๋กœ ํšŒ์›๊ฐ€์ž…ํ•œ ๋ฐ์ดํ„ฐ ๋„ฃ๊ธฐ)

* fix: Jwt ๊ธฐ์กด ์ธ์ฆ ํ† ํฐ์— ๋งž๊ฒŒ Oauth2 ๋ณ€๊ฒฝํ•˜๋Š” ๋กœ์ง ์ถ”๊ฐ€

* refactor: ๋งˆ๊ฐ์ž„๋ฐ• ๋ถํ† ํฌ ์กฐํšŒ ๋ฆฌํŒฉํ† ๋ง (#87)

(cherry picked from commit 416530e)

* fix: unused import ์ œ๊ฑฐ

* chore: ์ฃผ์„ ๋ณ€๊ฒฝ

* feat: ์นด์นด์˜ค, ๋„ค์ด๋ฒ„ ์†Œ์…œ ๋กœ๊ทธ์ธ ๊ตฌํ˜„

---------

Co-authored-by: Suhyeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๊ฐœ๋ฐœ ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ ํ–ˆ์„ ๋•Œ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[add] auditing ์ˆ˜์ •
2 participants