[FEAT/#105] 탐색 뷰 더미데이터 연결 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
requested changes
Jan 21, 2025
Comment on lines
35
to
55
| private fun getCategoryList() { | ||
| viewModelScope.launch { | ||
| runCatching { | ||
| exploreRepository.getCategoryList() | ||
| .onSuccess { response -> | ||
| _state.update { | ||
| it.copy( | ||
| categoryList = UiState.Success(response.toImmutableList()) | ||
| ) | ||
| } | ||
| } | ||
| .onFailure { | ||
| _state.update { | ||
| it.copy( | ||
| categoryList = UiState.Failure("카테고리 목록 조회 실패") | ||
| ) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
p1) Repository에서 이미 Result 객체로 보내주고 있는데 한번 더 runCatching으로 묶은 이유가 있을까요?
There was a problem hiding this comment.
제가 runCatching이 뭔지,,, 까먹었나봅니다,,,ㅋㅋㅋ큐ㅠ
…mock-data # Conflicts: # app/src/main/java/com/spoony/spoony/data/di/RepositoryModule.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_Recording_20250122_010650_Spoony-Android.mp4
Uncompleted Tasks 😅
To Reviewers 📢
서버에서 태그 텍스트컬러랑 배경컬러 바꿔서 저장해가지고 지금 두개가 섞여서 오고 있는데 전달해두었으니 참고 부탁드립니다!!