[FEAT/#117] 장소 검색 API 세팅 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chattymin
requested changes
Jan 22, 2025
Comment on lines
6
to
20
| @Serializable | ||
| data class BaseResponse<T>( | ||
| @SerialName("success") | ||
| val success: Boolean, | ||
| @SerialName("error") | ||
| val error: ErrorResponse? = null, | ||
| @SerialName("data") | ||
| val data: T? = null | ||
| ) | ||
|
|
||
| @Serializable | ||
| data class ErrorResponse( | ||
| @SerialName("message") | ||
| val message: String | ||
| ) |
There was a problem hiding this comment.
p4) 추후 세홍이형 PR 머지하게되면 충돌 날 것 같아요!
꼭 해결하고 머지부탁드려요 :)
Comment on lines
7
to
16
| fun PlaceDto.toPlaceEntity(): PlaceEntity = | ||
| PlaceEntity( | ||
| placeName = placeName, | ||
| placeAddress = placeAddress, | ||
| placeRoadAddress = placeRoadAddress, | ||
| latitude = latitude, | ||
| longitude = longitude | ||
| ) | ||
|
|
||
| fun PlaceEntity.toPlace(): Place = |
There was a problem hiding this comment.
p2) 함수명이 저희 컨벤션과 다른 것 같습니다! 수정 해주세요~
There was a problem hiding this comment.
코딩 컨벤션과 맞게 수정했습니다~
Comment on lines
62
to
70
| override suspend fun searchPlace(query: String, display: Int): Result<List<Place>> = runCatching { | ||
| val response = placeDataSource.searchPlace(query, display) | ||
| if (!response.success || response.data == null) { | ||
| throw IllegalStateException(response.error?.message ?: "에러 발생") | ||
| } | ||
| response.data.placeList.map { placeDto -> | ||
| placeDto.toPlaceEntity().toPlace() | ||
| } | ||
| } |
There was a problem hiding this comment.
p1) 저희 컨벤션 맞게 runCatching 내부에서 !!를 사용하는 방법으로 부탁드려요!
There was a problem hiding this comment.
override suspend fun searchPlace(query: String, display: Int): Result<List<Place>> = runCatching {
placeDataSource.getPlaces(query, display).data!!.placeList
.map { it.toDomain().toPresentation() }
}로 수정했습니다!
Hyobeen-Park
requested changes
Jan 22, 2025
| import com.spoony.spoony.domain.entity.PlaceEntity | ||
| import com.spoony.spoony.presentation.register.model.Place | ||
|
|
||
| fun PlaceDto.toPlaceEntity(): PlaceEntity = |
There was a problem hiding this comment.
P1: 저희 컨벤션에 맞게 함수명 고쳐주세요~~!!
There was a problem hiding this comment.
P1: 컨벤션에 맞게 네이밍 수정해봅시다~~ 노션 읽어라~~
Hyobeen-Park
requested changes
Jan 22, 2025
Comment on lines
8
to
9
| import com.spoony.spoony.presentation.register.model.Category | ||
| import com.spoony.spoony.presentation.register.model.Place |
There was a problem hiding this comment.
P1: 어라라????? data레이어에서 presentation 레이어의 모델을 사용하네요?? 수정해주세요!!
…arch-api # Conflicts: # app/src/main/java/com/spoony/spoony/data/di/DataSourceModule.kt # app/src/main/java/com/spoony/spoony/data/di/ServiceModule.kt
chattymin
approved these changes
Jan 22, 2025
Comment on lines
43
to
48
| Category( | ||
| categoryId = entity.categoryId, | ||
| categoryName = entity.categoryName, | ||
| iconUrlSelected = entity.iconUrl, | ||
| iconUrlNotSelected = entity.unSelectedIconUrl ?: entity.iconUrl | ||
| ) |
There was a problem hiding this comment.
p4) Category를 선언한 곳에서 mapper를 만들어 주는 방법도 있답니다~
Hyobeen-Park
approved these changes
Jan 22, 2025
Comment on lines
64
to
70
| Place( | ||
| placeName = entity.placeName, | ||
| placeAddress = entity.placeAddress, | ||
| placeRoadAddress = entity.placeRoadAddress, | ||
| latitude = entity.latitude, | ||
| longitude = entity.longitude | ||
| ) |
There was a problem hiding this comment.
P3: mapper 함수를 만들어주는건 어떤가요??
| searchResults = places.toImmutableList(), | ||
| isSearching = false | ||
| .onSuccess { placeEntities -> | ||
| val places = placeEntities.map { entity -> |
There was a problem hiding this comment.
P3: value로 한번 저장해주는 이유가 있으신가요?? 가능하면 객체로 저장하지 말고 바로 state에 넣어주면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
To Reviewers 📢
Entity 만들어서 사용하시면 됩니다.