Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/#164] 신고하기 뷰에서 탐색 뷰 이동 시 nav 수정 #169

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

Roel4990
Copy link
Member

Related issue 🛠

Work Description ✏️

  • 신고하기 뷰에서 탐색 뷰 이동 시 nav 수정

Screenshot 📸

nav.mp4

To Reviewers 📢

@Roel4990 Roel4990 added FIX🔨 버그 및 오류 해결 🧡세홍🧡 🧡세홍🧡 labels Jan 23, 2025
@Roel4990 Roel4990 self-assigned this Jan 23, 2025
@Roel4990 Roel4990 requested a review from a team as a code owner January 23, 2025 21:22
@Roel4990 Roel4990 linked an issue Jan 23, 2025 that may be closed by this pull request
1 task
Copy link
Collaborator

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸푸!!!

navOptions: NavOptions? = navOptions {
popUpTo(Explore) {
inclusive = false
[email protected] = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: 이거 this.@navOptions 없이도 가능하지 않나요..??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: 이거 그냥 들어갑니다~ 네비 공부해보기~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다! 아래로 옮기면 되네요!

Copy link
Collaborator

@angryPodo angryPodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM....

navOptions: NavOptions? = navOptions {
popUpTo(Explore) {
inclusive = false
[email protected] = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this@navOptions.restoreState = true
restoreState = true

p1) 도 될껄요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

@Roel4990 Roel4990 merged commit e576c16 into develop Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIX🔨 버그 및 오류 해결 🧡세홍🧡 🧡세홍🧡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 장소 상세, 신고 페이지 네비게이션 설정 이슈
4 participants