[FEAT/#59] 네이버 길찾기 기능 및 함수 구현 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| } | ||
| context.startActivity(marketIntent) | ||
| } else { | ||
| context.startActivity(intent) |
There was a problem hiding this comment.
Suggested change
| context.startActivity(intent) | |
| Intent(Intent.ACTION_VIEW, Uri.parse(url)).apply { | |
| addCategory(Intent.CATEGORY_BROWSABLE) | |
| context.startActivity(this) | |
| } |
P3: 위에서 intent를 저장하지 않고 이렇게도 사용 가능합니다!
Comment on lines
275
to
278
| val marketIntent = Intent(Intent.ACTION_VIEW).apply { | ||
| data = Uri.parse("market://details?id=com.nhn.android.nmap") | ||
| } | ||
| context.startActivity(marketIntent) |
There was a problem hiding this comment.
P3: 여기도 꼭 필요한 것이 아니라면 변수에 저장하기 보다는 객체를 바로 사용해주는 것이 어떨까요?
Hyobeen-Park
approved these changes
Jan 21, 2025
| } catch (e: PackageManager.NameNotFoundException) { | ||
| false | ||
| } | ||
| if (!isInstalled) { |
There was a problem hiding this comment.
Suggested change
| if (!isInstalled) { | |
| if (isInstalled) { |
P4: 이렇게 ! 안붙은거 먼저 해주면 너무 좋을 것 같아요..!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
default.mp4
default.mp4
To Reviewers 📢