Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential performance improvements #3598

Merged
merged 10 commits into from
Jan 7, 2021
Merged

Potential performance improvements #3598

merged 10 commits into from
Jan 7, 2021

Conversation

HolgerReiseVSys
Copy link
Contributor

@HolgerReiseVSys HolgerReiseVSys commented Nov 26, 2020 •
edited by MartinWahnschaffe
Loading

@HolgerReiseVSys HolgerReiseVSys added discuss Discussion about whether or not the issue should or can be implemented required performance Issues that are meant to increase the performance of the application labels Nov 26, 2020
@HolgerReiseVSys
Copy link
Contributor Author

I have noticed that in PersonService::buildSimilarityCriteriaFilter cb.literal(name) is set directly, not a parameter.
Same goes for the other filters.
Having a reusable query definition could be beneficial to import performance.

@MartinWahnschaffe MartinWahnschaffe mentioned this pull request Jan 5, 2021
Closed
1 task
@MartinWahnschaffe
Copy link
Contributor

@HolgerReiseVSys unit tests throw exception

org.jboss.weld.context.ContextNotActiveException: WELD-001303: No active contexts for scope type javax.transaction.TransactionScoped

I will continue to look into this tomorrow, but if you have a quick idea on this, let me know.

@MartinWahnschaffe MartinWahnschaffe merged commit b025187 into development Jan 7, 2021
@JonasCir JonasCir deleted the potential_performance_improvements branch January 8, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateStrysewske MateStrysewske Awaiting requested review from MateStrysewske

@MartinWahnschaffe MartinWahnschaffe Awaiting requested review from MartinWahnschaffe

Assignees
No one assigned
Labels
discuss Discussion about whether or not the issue should or can be implemented required performance Issues that are meant to increase the performance of the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HolgerReiseVSys @MartinWahnschaffe