[FFS] Facilitation du restock des vêtements en rupture #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there an existing issue for this? I have searched the existing issues In which category does your improvement fall? FFS Explain the current situation that you do not think is right. Aujourd'hui, le restock des magasins de vêtements par FFS est fait de manière aléatoire, ce qui fait que certains vêtements (qui ne sont pas/peu achetés) sont présents en très grand nombre, alors que les items très achetés sont régulièrement en rupture de stock et difficile à restock. En étant astucieux, les joueurs de FFS peuvent ajuster leur production de vêtements afin de répondre, le plus possible, au rupture. Cependant, au vu de la très grande quantité de vêtements, ces ajustements dans le RP sont insuffisant et je penses qu'un petit coup de pousse serait de mise. How is the improvement you propose? Le premier changement que je propose est d'empécher le restock des modèles d'articles ayant plus de 50(ce chiffre peut changer) vêtements en stock, et cela afin de favorisé les vêtements en rupture. Enfin, le second changement est d'indiquer au joueur quel modèle il met en stock.
1 task
DreamXZE
reviewed
Nov 28, 2024
| ); | ||
|
|
||
| let randomItem; | ||
| if (!itemStock) { |
There was a problem hiding this comment.
Suggested change
| if (!itemStock) { | |
| if (!itemStock.length) { |
Ca marche en python, mais pas en JS 🙏
There was a problem hiding this comment.
Ah mince! X) je pensais que ça marchais pcq j'avais vu cette ligne (Je suis néophyte en TS )
" if (!randomItem || !loopItems) {" (ligne 179)
Pim-612
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR pour l'issue #351