-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRSDM-3614: updated logic with the newlines for the quote block #3
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure how to test it locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind I thought this was in enterprise repo... ignore me
@WiaanB if I remember correctly, on these repos if you merge to develop, it auto publishes a test version and if you merge to main it publishes the official new version. Could we maybe get this into develop with a code review or 2, then with the test version someone else can do a local test and we can have a single review on dev->master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good, but would like to test locally if we could do an unofficial version
Since we're modifying the forked code now anyway, and the forked repo is pretty simple, would it not make sense to rather just add this code our Then we don't need to worry about maintaining this repo or build processes and ultimately we can get rid of this packages dependency. |
No description provided.