Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRSDM-3614: updated logic with the newlines for the quote block #3

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

WiaanB
Copy link

@WiaanB WiaanB commented Apr 9, 2024

No description provided.

Copy link

@kmorake kmorake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure how to test it locally

Copy link

@Zalaras Zalaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind I thought this was in enterprise repo... ignore me

@CharlRitterDev
Copy link

@WiaanB if I remember correctly, on these repos if you merge to develop, it auto publishes a test version and if you merge to main it publishes the official new version.

Could we maybe get this into develop with a code review or 2, then with the test version someone else can do a local test and we can have a single review on dev->master?

Copy link

@CharlRitterDev CharlRitterDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good, but would like to test locally if we could do an unofficial version

@WiaanB WiaanB changed the base branch from master to develop April 10, 2024 07:48
@zelrestemmet
Copy link

Since we're modifying the forked code now anyway, and the forked repo is pretty simple, would it not make sense to rather just add this code our presidium-js-enterprise repo? Like we're adding the embed plugins now?

Then we don't need to worry about maintaining this repo or build processes and ultimately we can get rid of this packages dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants