Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add key algorithm for acm certificate, update docs #25

Merged
merged 1 commit into from
Aug 30, 2023
Merged

add key algorithm for acm certificate, update docs #25

merged 1 commit into from
Aug 30, 2023

Conversation

hong-yi
Copy link
Contributor

@hong-yi hong-yi commented Aug 29, 2023

SCP requires the key_algorithm key to be specified or else terraform apply will fail. Updated the documentation to reflect new variable.

@hong-yi hong-yi requested a review from niroz89 August 30, 2023 02:21
shisheng10
shisheng10 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@shisheng10 shisheng10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong-yi hong-yi merged commit 209e95a into main Aug 30, 2023
3 checks passed
@hong-yi hong-yi deleted the add/acm-key-algo branch August 30, 2023 03:21
zodilib pushed a commit that referenced this pull request Nov 12, 2024
@hong-yi
add key algorithm for acm certificate (#25)
e7064a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisheng10 shisheng10 shisheng10 approved these changes

@niroz89 niroz89 Awaiting requested review from niroz89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hong-yi @shisheng10