implement aws recommended alarms for managed opensearch #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niroz89
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Help to clean up commented code and unused variables. It's good to have option to,
- override alarm values:
alarm_overrides - disable alarms:
disabled_alarms
you can take reference on how it's done here: https://github.com/terraform-aws-modules/terraform-aws-cloudwatch/blob/master/modules/cis-alarms/main.tf
|
Made the change to disable and override alarms. Test plan: https://app.terraform.io/app/sph/workspaces/platform-eng-logging-base-dev/runs/run-8m6PaZ3zz2hk9JE8 |
abhinavkumarsph
requested review from
a team,
francishokh and
Madhukar55
and removed request for
a team
niroz89
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the documentation here