Skip to content

Commit

Permalink
Merge pull request #3 from SPHTech-Platform/fix-output
Browse files Browse the repository at this point in the history
Fix output and by default create role to make the module non breaking
  • Loading branch information
niroz89 authored Jun 16, 2022
2 parents 6c4577d + 49ee9fb commit 4679f82
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 4.18.0 |
| <a name="provider_helm"></a> [helm](#provider\_helm) | 2.5.1 |
| <a name="provider_http"></a> [http](#provider\_http) | 2.2.0 |
| <a name="provider_kubernetes"></a> [kubernetes](#provider\_kubernetes) | 2.11.0 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 4.18 |
| <a name="provider_helm"></a> [helm](#provider\_helm) | >= 2.5 |
| <a name="provider_http"></a> [http](#provider\_http) | >= 2.2.0 |
| <a name="provider_kubernetes"></a> [kubernetes](#provider\_kubernetes) | >= 2.11 |

## Modules

Expand Down Expand Up @@ -47,7 +47,7 @@
| <a name="input_chart_timeout"></a> [chart\_timeout](#input\_chart\_timeout) | Timeout to wait for the Chart to be deployed. | `number` | `300` | no |
| <a name="input_chart_version"></a> [chart\_version](#input\_chart\_version) | Version of Chart to install. Set to empty to install the latest version | `string` | `"1.1.2"` | no |
| <a name="input_cluster_name"></a> [cluster\_name](#input\_cluster\_name) | Name of Kubernetes Cluster | `string` | n/a | yes |
| <a name="input_create_default_irsa"></a> [create\_default\_irsa](#input\_create\_default\_irsa) | Create default IRSA for service account | `bool` | `false` | no |
| <a name="input_create_default_irsa"></a> [create\_default\_irsa](#input\_create\_default\_irsa) | Create default IRSA for service account | `bool` | `true` | no |
| <a name="input_external_secrets_secrets_manager_arns"></a> [external\_secrets\_secrets\_manager\_arns](#input\_external\_secrets\_secrets\_manager\_arns) | List of Secrets Manager ARNs that contain secrets to mount using External Secrets | `list(string)` | <pre>[<br> "arn:aws:secretsmanager:*:*:secret:*"<br>]</pre> | no |
| <a name="input_external_secrets_ssm_parameter_arns"></a> [external\_secrets\_ssm\_parameter\_arns](#input\_external\_secrets\_ssm\_parameter\_arns) | List of Systems Manager Parameter ARNs that contain secrets to mount using External Secrets | `list(string)` | <pre>[<br> "arn:aws:ssm:*:*:parameter/*"<br>]</pre> | no |
| <a name="input_iam_role_description"></a> [iam\_role\_description](#input\_iam\_role\_description) | Description for IAM role for controller | `string` | `"Used by AWS Load Balancer Controller for EKS"` | no |
Expand Down
8 changes: 4 additions & 4 deletions outputs.tf
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
output "iam_role_arn" {
description = "ARN of IAM role"
value = module.secrets_manager_role[0].iam_role_arn
value = try(module.secrets_manager_role[0].iam_role_arn, "")
}

output "iam_role_name" {
description = "Name of IAM role"
value = module.secrets_manager_role[0].iam_role_name
value = try(module.secrets_manager_role[0].iam_role_name, "")
}

output "iam_role_path" {
description = "Path of IAM role"
value = module.secrets_manager_role[0].iam_role_path
value = try(module.secrets_manager_role[0].iam_role_path, "")
}

output "iam_role_unique_id" {
description = "Unique ID of IAM role"
value = module.secrets_manager_role[0].iam_role_unique_id
value = try(module.secrets_manager_role[0].iam_role_unique_id, "")
}
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ variable "external_secrets_secrets_manager_arns" {
variable "create_default_irsa" {
description = "Create default IRSA for service account"
type = bool
default = false
default = true
}

variable "namespace" {
Expand Down

0 comments on commit 4679f82

Please sign in to comment.