Skip to content

Commit

Permalink
refactor: fix ascp image path (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
uchinda-sph authored Nov 11, 2024
1 parent b091127 commit 69a4cc8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
1 change: 0 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ locals {
}

ascp_values = {
image_registry = var.ascp_image_registry
image_repository = var.ascp_image_repository
image_tag = var.ascp_image_tag

Expand Down
1 change: 0 additions & 1 deletion templates/ascp.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
imagePullSecrets: []

image:
registry: ${image_registry}
repository: ${image_repository}
## defaults to app.Version
tag: ${image_tag}
Expand Down
16 changes: 5 additions & 11 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ variable "chart_repository" {
variable "chart_version" {
description = "Version of Chart to install. Set to empty to install the latest version"
type = string
default = "1.4.3"
default = "1.4.6"
}

variable "chart_namespace" {
Expand Down Expand Up @@ -69,7 +69,7 @@ variable "image_repository_crds" {
variable "image_tag" {
description = "Image tag for the Driver and CRDs"
type = string
default = "v1.4.3"
default = "v1.4.6"
}

variable "resources_driver" {
Expand Down Expand Up @@ -226,7 +226,7 @@ variable "ascp_chart_repository" {
variable "ascp_chart_version" {
description = "Version of ASCP chart to install. Set to empty to install the latest version"
type = string
default = "0.3.8"
default = "0.3.10"
}

variable "ascp_chart_namespace" {
Expand All @@ -241,22 +241,16 @@ variable "ascp_chart_timeout" {
default = 300
}

variable "ascp_image_registry" {
description = "Image registry of the ASCP"
type = string
default = "public.ecr.aws"
}

variable "ascp_image_repository" {
description = "Image repository of the ASCP"
type = string
default = "aws-secrets-manager/secrets-store-csi-driver-provider-aws"
default = "public.ecr.aws/aws-secrets-manager/secrets-store-csi-driver-provider-aws"
}

variable "ascp_image_tag" {
description = "Image tag of the ASCP"
type = string
default = "1.0.r2-68-gab548b3-2024.03.20.21.58"
default = "1.0.r2-75-g1f97be0-2024.10.17.19.45"
}

variable "ascp_node_selector" {
Expand Down

0 comments on commit 69a4cc8

Please sign in to comment.