Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
cnordhougen authored Feb 5, 2024
1 parent e0b3eba commit 6bfcb26
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@

## What?

About 10 years ago, AirBnB's engineers created a style guide and explained their reasoning in this way: "Everyone writes JavaScript a little differently. We finally decided it was time that we got together and agree on how we write JavaScript." SPS Commerce engineers have talked about the need for unified lint rules and a style guide for almost as long, but in 2022 we all new development is done in Typescript instead of Javascript. In this guide we've taken what we feel are the best parts of the AirBnB guide and made it our own.
About 10 years ago, AirBnB's engineers created a style guide and explained their reasoning in this way: "Everyone writes JavaScript a little differently. We finally decided it was time that we got together and agree on how we write JavaScript." SPS Commerce engineers have talked about the need for unified lint rules and a style guide for almost as long, but in 2024 we all new development is done in Typescript instead of Javascript. In this guide we've taken what we feel are the best parts of the AirBnB guide and made it our own.

It is broken down in to 3 sections:

- [Typescript](./typescript/)
- [React](./react/)
- [CSS in JS](./css-in-js/)
- [React](./react/) (This is straight from the original AirBnB repo and has not been reviewed by us yet.)

## Why?

Expand All @@ -22,10 +21,10 @@ This is the hard part to write, but we'll get there soon...

The work to define this guide and choose which rules were include was done by the SPS Frontend Architecture Working group in 2021.

- Christopher Nordhougen ([@cnordhougen](https://github.com/cnordhougen))
- Chris Nordhougen ([@cnordhougen](https://github.com/cnordhougen))
- Justin Turner ([@turnerjw](https://github.com/turnerjw))
- Dima Surkov ([@DimaSurkov](https://github.com/DimaSurkov))
- Jake Freeberg ([@jakefreeberg](https://github.com/jakefreeberg))
- Alex Ivakhnenko([@alexander-ivakhnenko](https://github.com/alexander-ivakhnenko))
- Alex Ivakhnenko ([@alexander-ivakhnenko](https://github.com/alexander-ivakhnenko))
- Ihor Kuzmenko ([@IgorKuzmenko](https://github.com/IgorKuzmenko))
- Andy Sciro ([@spssciro](https://github.com/spssciro))

0 comments on commit 6bfcb26

Please sign in to comment.