Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add Contents]: Image Representation & storing format #82

Closed
wants to merge 11 commits into from

Conversation

ChinmayMundane
Copy link
Contributor

This solves the issue #59
includes :

  • cpp file containing the code to read from bitmap image and then store it to display, using sdl2 library
  • images
  • readme file explaining the theory

ChinmayMundane and others added 8 commits March 21, 2023 16:58
includes : 
- cpp file containing the code to read from bitmap image and then store it to display, using sdl2 library
- images
- readme file explaining the theory
* Update Makefile to remove redundant "SDL2_image" linker flag
* Add proper implementation of SDL2 library to display correct
  size of image
* This commit resolves the bug wherein image was displayed inverted.
* Two seperate struct "BitMapFileHeader" and "BitMapInfoHeader" is
  created to store the file type data and image information data.
* README.md has been modified to include more info about the different
  blocks in the bitmap image namely file data type, image information
  data , color pallete and raw raster data.
Copy link
Collaborator

@amanchhaparia amanchhaparia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unnecessary line-breaks wherever required.

Comment on lines 35 to 40
- As most of the time, representation

refers to the way that brings information, such as color is coded digitally,

and how the image is stored, i.e., how an image file is structured.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary linebreaks

3_cv_basics/1_image_representation/README.md Show resolved Hide resolved
Comment on lines 48 to 56
A pixel includes its own:-

● Intensity

● Name or Address

The size of the image is defined as the total number of pixels in the horizontal direction times the total

number of pixels in the vertical direction. For eg: (512 x 512,640 x 480, or 1024 x 768).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary line breaks.

Changes made :
- Removed the unnecessary linebreak wherever required.
- Seperated types of images from "some important terminologies" topic
@ChinmayMundane
Copy link
Contributor Author

Linebreaks have been removed and topic has been renamed as suggested.
Kindly review and let me know if any changes are required.

@amanchhaparia amanchhaparia marked this pull request as ready for review March 23, 2023 08:20
@amanchhaparia
Copy link
Collaborator

@ChinmayMundane, kindly follow the file structure as defined on the dev branch

@amanchhaparia amanchhaparia changed the title Add content for image storing formats [Add Contents]: Image Representation & storing format Mar 23, 2023
ChinmayMundane and others added 2 commits March 23, 2023 15:57
- Added proper path to asset images
- added correct command for run without make
@ChinmayMundane
Copy link
Contributor Author

File structure has been modified, please check if its correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants