Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved efficiency and code reuse with templates and pure functions #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@SRombauts SRombauts self-assigned this Dec 24, 2019
@SRombauts
Copy link
Owner

Hello, thanks again for this new series of pull requests. Have you seen that they have all failed CI?

@KOLANICH
Copy link
Contributor Author

Hello, thanks again for this new series of pull requests.

Not quite new, just splitted the old #182 into multiple PRs.

no template named 'enable_if' in namespace 'std'
error: ‘enable_if’ in namespace ‘std’ does not name a template type

Old versions of C++ should be dropped.

@emmenlau
Copy link
Contributor

@KOLANICH I find your PR very valuable but I think it may be easier to digest if split into again smaller parts.

@SRombauts What is your take on the points raised by KOLANICH? Lets take one aspect out, templates. Would you agree that adding stronger use of templates is a good thing? I recently had to fix something about the types in Statement::bind(), and I found what KOLANICH also found, that these methods are quite lengthy code for a thing that would become much shorter and cleaner with templates.

Would you accept a PR that adds stronger use of templates (for better code reuse and shortening of the existing code)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants