This repository has been archived by the owner on Apr 27, 2024. It is now read-only.
Shipyards and bank system from Frontier Station #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable shipyard (cherry picked from commit 240e845)
* Shipyard show sell price * Sell Price * Update ShipyardSystem.Consoles.cs * FTL (cherry picked from commit 8d5169f)
* Fix Channel for STC * Update ShipyardSystem.Consoles.cs * Update ShipyardSystem.Consoles.cs * Update ShipyardSystem.Consoles.cs * Fix * Merge branch 'STC2' of https://github.com/dvir001/frontier-station-14… * Merge branch 'new-frontiers-14:master' into STC2 (cherry picked from commit f27b6a1)
* The first implementation: renaming does work, but is not displayed on the radar * Fix renaming a ship not affecting the radar control * Add I18N strings * Fix saving the shuttle name not making the save button disabled * Empty the shuttle name field if the interface is disabled * Split shuttle name into 3 fields and add length constraints * Rework ShuttleDeed totally to support 3 distinct name parts, update ShipyardSystem.Consoles.cs to parse shuttle names * Fix an oopsie * Inline GetNameParts and JoinNameParts, and move GetFullName to ShipyardSystem * Log shuttleUid instead of ShuttleOwner * Move messages from IdCardConsoleComponent.cs to SharedIdCardSystem.cs * Cleanup * Disable prefix parsing until further notice * Rip prefixes out of the code as though they never existed (cherry picked from commit e411689)
* Testing * Deed * Update ShuttleDeedComponent.cs * Update ShuttleDeedComponent.cs * Update ShipyardSystem.Consoles.cs * No Need for this lines * Fixing * I used ChatGPT to fix this * Small change to fix errors * Update ShipyardSystem.Consoles.cs * Fix * Fixing * Update shuttle.yml * Working again * Added owner name to card * Deed Testing * Update ShipyardSystem.Consoles.cs * Working Again. * Fix * Fix for ID comp (cherry picked from commit edaca48)
* Update ShipyardSystem.Consoles.cs * Changes * Update shipyard-console-component.ftl Not saving, mrpf * Update shipyard-console-component.ftl (cherry picked from commit 8a196b2)
* Did the deed * Fix spectre's name tag * Removed the None ui key * Typo * Limit the empress' console to just 3 ships * Cleanup * Remove unused name field (cherry picked from commit d381c3c)
* Create ShipyardTests.cs * Fix shipyard test failures * Remove map changes * Update rosebudmki.yml --------- Co-authored-by: Dvir <[email protected]> (cherry picked from commit 0277223)
) * refactor(ui): Rename shipyard ui labels for consistency with `BankATMMenu` and `CargoPalletMenu` * refactor(loc): Remove redundant shipyard localization ids * refactor(loc): Rename a shipyard localization id for consistency with `CargoPalletMenu` * refactor(loc): Consolidate extraneous shipyard localization file * refactor(loc): Move shipyard localization file into `_NF` directory (cherry picked from commit 0c95e7d)
…` and `CargoPalletMenu` (space-wizards#998) (cherry picked from commit f1d8141)
|
closing this because of rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep Station 14 Pull Request
Attempt at porting Shipyards from Frontier station.
This will be an interesting opportunity for all departments. It will be closely managed however to make sure it doesn't detract from overall station gameplay, but may come into greater use as our salvage and expeditions plans materialise.
Shipyards currently rely on the bank stuff from Frontier which is something similar to what we want in future so this will need removing till then or adapted for now.
Checklist: