Restore old IPC emotes and Include them on Harpies #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thing is, I have no IDEA why "params" on emoteSounds REPLACE all params from the sounds defined bellow INSTEAD of just acting as a default value... WHY?
|
looks good to me |
what a dumb mistake
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Oh hey, I apologize for not noticing this, because I mainly do all my dev and maintainer work on the EE discord. If you wish to continue developing IPC, I would actually suggest that we make a PR to Einstein Engines adding all of the new IPC content there, which'll make my life a hell of a lot easier with running the playtests here. |
|
Going to close this due to there actually being several more errors behind the one github is showing, because most of these changes were done upstream on EE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep Station 14 Pull Request
About the PR
Why / Balance
Technical details
IPCBeep was re-enabled but its triggers were changed so it would not conflict with HarpyBeep
"HarpyBeep" is nothing more than a trigger emote, that means it can be used to trigger the emote sound when the user uses one of the chatTriggers. There's no need to create another emote prototype. Instead, HarpyBeep was reused to play a different sound while they are triggered by IPCs.
Media
2024-07-14.00-10-41.mp4