Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily re-add hugging #67

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

BasedUser
Copy link
Contributor

About the PR

This PR reverts Einstein-Engines#710.

Why / Balance

The upstream PR wasn't cleanly merged into DS14, and caused several species to break (notably, lamia and IPCs). So far, there isn't a good replacement (a very small variety of humanoid interactions), so I believe it's best to revert for now and let Rane cook.
I don't believe the RP level in DS14 will get impacted as it is currently.

Technical details

Literally just adds the components back.
When reverting this, you might want to keep the .ftl's in case something weird happens.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

🆑 router

  • tweak: Temporarily added hugging back due to problems with alternate species. This may remain permanently if nothing comes to replace it.

@Mnemotechnician
Copy link
Contributor

We have this PR open on ee: Simple-Station/Einstein-Engines#733

@BasedUser
Copy link
Contributor Author

EE#733 isn't complete, so not closing as duplicate, but this will be a breaking change

@VMSolidus VMSolidus merged commit 40e75f0 into SS14-Classic:master Aug 20, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants