Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💸 Presenter has needlessly nested props #2967

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

fenix2222
Copy link
Contributor

@fenix2222 fenix2222 requested a review from wicksipedia as a code owner August 17, 2024 07:14
Copy link
Contributor

github-actions bot commented Aug 17, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.22% 69/31072
🔴 Branches 7.57% 24/317
🔴 Functions 1.01% 3/296
🔴 Lines 0.22% 69/31072

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 06e10e6

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2967.azurewebsites.net

Copy link
Contributor

github-actions bot commented Sep 6, 2024

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 62
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2967.azurewebsites.net

@Calinator444
Copy link
Member

Calinator444 commented Sep 9, 2024

@fenix2222

@amankumarrr is updating the cron job which syncs presenters from people. We would need to run it before merging this so that the Schema gets updated. Unfortunately I can't merge this right now because it would have breaking changes.

image
Figure: Wicksy & Cooky's names missing due to schema change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💸 Presenter has needlessly nested props
3 participants