💄V2 Card component - added option to embed Youtube videos inside the card carousel #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from a55a8f1 |
Calinator444
changed the title
Calinator444
changed the title
|
Deployed changes to https://app-sswwebsite-9eb3-pr-3476.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3476.azurewebsites.net |
isaaclombardssw
requested changes
Jan 10, 2025
isaaclombardssw
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM – so this doesn't block you. But look into the 16:9 aspect ratio as per our conversation with @bettybondoc
|
Deployed changes to https://app-sswwebsite-9eb3-pr-3476.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3476.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected routes: /consulting/*
Fixed ✨ Add YouTube Video Embedding to Cards Component #3474
Include done video or screenshots
Figure: Video embed in stacked layout
Figure: Video embed in carousel layout
Figure: Youtube embed field on card component